Skip to content

refactor(framework): Remove unused GetFab endpoint#6515

Merged
danieljanes merged 1 commit intomainfrom
rm-getfab-endpoint
Feb 4, 2026
Merged

refactor(framework): Remove unused GetFab endpoint#6515
danieljanes merged 1 commit intomainfrom
rm-getfab-endpoint

Conversation

@danieljanes
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings February 3, 2026 20:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused GetFab endpoint from the ServerAppIo service. The endpoint was previously used to retrieve FAB (Flower Application Bundle) files from the Flower File System (Ffs) but is no longer needed.

Changes:

  • Removed the GetFab RPC method from the ServerAppIo service definition
  • Removed the GetFab implementation from the ServerAppIoServicer
  • Cleaned up unused imports related to FAB functionality

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
framework/proto/flwr/proto/serverappio.proto Removed GetFab RPC method definition from service
framework/py/flwr/proto/serverappio_pb2.py Updated auto-generated protobuf file to reflect removal
framework/py/flwr/proto/serverappio_pb2_grpc.py Removed GetFab stub and servicer implementations
framework/py/flwr/proto/serverappio_pb2_grpc.pyi Removed GetFab type hints and method signatures
framework/py/flwr/server/superlink/serverappio/serverappio_servicer.py Removed GetFab method implementation and unused imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danieljanes danieljanes changed the title refactor(framework): Removed unused GetFab endpoint refactor(framework): Remove unused GetFab endpoint Feb 3, 2026
@danieljanes danieljanes enabled auto-merge (squash) February 3, 2026 20:27
@github-actions github-actions bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Feb 3, 2026
Copy link
Member

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@danieljanes danieljanes merged commit b6224af into main Feb 4, 2026
70 of 71 checks passed
@danieljanes danieljanes deleted the rm-getfab-endpoint branch February 4, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants