Skip to content

Fix: Infinite loop in bower checks (fixes #186) #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverfoster merged 1 commit into from
Feb 21, 2023
Merged

Fix: Infinite loop in bower checks (fixes #186) #188

oliverfoster merged 1 commit into from
Feb 21, 2023

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 14, 2023

fixes #186

Fix

  • Typo correction at counting attempts

@oliverfoster oliverfoster self-assigned this Feb 14, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 439f84b into master Feb 21, 2023
github-actions bot pushed a commit that referenced this pull request Feb 21, 2023
@semantic-release-bot
Chore(release): 3.0.11 [skip ci]
f3a2e37 
## [3.0.11](v3.0.10...v3.0.11) (2023-02-21)

### Fix

* Infinite loop in bower checks (fixes #186) (#188) ([439f84b](439f84b)), closes [#186](#186) [#188](#188)
@github-actions
Copy link

github-actions bot commented Feb 21, 2023

🎉 This PR is included in version 3.0.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster deleted the issue/186 branch February 21, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taylortom taylortom taylortom approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

Assignees

@oliverfoster oliverfoster

Labels

bug released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plugin.getBowerInfo can get stuck in an infinite retry loop

5 participants

@oliverfoster @taylortom @cahirodoherty-learningpool @eleanor-heath