Conversation
taylortom
added a commit
to adapt-security/adapt-authoring-adaptframework
that referenced
this pull request
Mar 24, 2026
The CLI's installFramework and updateFramework expect a specific version tag, not a semver range. Passing targetVersionRange directly caused a 404 when the CLI tried to download a GitHub archive using the range as a branch name. Now resolves the range via getLatestVersion() first. Also fixes typo: getLatestFrameworkVersion param should be versionLimit not version (refs adaptlearning/adapt-cli#241).
3 tasks
taylortom
added a commit
to adapt-security/adapt-authoring-adaptframework
that referenced
this pull request
Mar 24, 2026
The CLI's installFramework and updateFramework expect a specific version tag, not a semver range. Passing targetVersionRange directly caused a 404 when the CLI tried to download a GitHub archive using the range as a branch name. Now resolves the range via getLatestVersion() first. Also fixes typo: getLatestFrameworkVersion param should be versionLimit not version (refs adaptlearning/adapt-cli#241).
2 tasks
taylortom
added a commit
to adapt-security/adapt-authoring-adaptframework
that referenced
this pull request
Mar 24, 2026
The CLI's installFramework and updateFramework expect a specific version tag, not a semver range. Passing targetVersionRange directly caused a 404 when the CLI tried to download a GitHub archive using the range as a branch name. Now resolves the range via getLatestVersion() first. Also fixes typo: getLatestFrameworkVersion param should be versionLimit not version (refs adaptlearning/adapt-cli#241).
github-actions bot
pushed a commit
to adapt-security/adapt-authoring-adaptframework
that referenced
this pull request
Mar 24, 2026
## [2.5.4](v2.5.3...v2.5.4) (2026-03-24) ### Fix * Resolve semver range to concrete version before CLI install/update ([513d488](513d488)), closes [adaptlearning/adapt-cli#241](adaptlearning/adapt-cli#241)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#240
Update
versionLimitsemver range parameter to be passed through togetLatestVersionfrom the publicgetLatestFrameworkVersionAPI method, enabling callers to constrain which framework version is returned.Testing
api.getLatestFrameworkVersion({ versionLimit: '>=5.0.0 <6.0.0' })and verify it returns a version within the specified rangeapi.getLatestFrameworkVersion()withoutversionLimitand verify it still returns the latest version (no regression)