Conversation
|
Changes Unknown when pulling 90fe95c on dm-fix-filter-header-bug into ** on master**. |
malonecj
suggested changes
Dec 12, 2016
| }, | ||
|
|
||
| // Set the cell selection to -1 x -1 when clicking on the header | ||
| onHeaderClick() { |
Contributor
Author
There was a problem hiding this comment.
@malonecj sorry for the delay. It's done.
|
@diegomurakami Thank you for fixing this! Looking forward to the merge. |
|
Changes Unknown when pulling f568450 on dm-fix-filter-header-bug into ** on master**. |
malonecj
suggested changes
Jan 5, 2017
| const headerDiv = wrapper.find('div'); | ||
| headerDiv.simulate('click'); | ||
| expect(testAllProps.cellMetaData.onCellClick).toHaveBeenCalled(); | ||
| }); |
Contributor
There was a problem hiding this comment.
You should be verifying the parameters of cellMetaData. Its important to verify that the selected idx and rowIdx is -1,-1
|
Changes Unknown when pulling c46bc98 on dm-fix-filter-header-bug into ** on master**. |
malonecj
approved these changes
Jan 6, 2017
|
Changes Unknown when pulling 4c52568 on dm-fix-filter-header-bug into ** on master**. |
Contributor
Author
|
@malonecj haha thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #556
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
New checkFocus method was implemented recently on Cell component. This method checks the selected cell when filters are selected and used. The problem is that [0,0] is selected when filters are used, causing [0,0] to be focused after filter change.
What is the new behavior?
When the user clicks on the Header, we call a new method onHeaderClick which sets [-1,-1] as the current selection of the Grid using onCellClick from cellMetaData (injected as a new prop to the Header component).
Does this PR introduce a breaking change? (check one with "x")