feat(protocol): adopt AdCP 3.2 rc.0 - #1123
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean additive AdCP 3.2 beta.11 → rc.0 adoption.
Checked against the decision table top-down:
- Rows 1 (critical/high): no findings — none present.
- Row 2 (gated_paths):
gated_paths: false, so does not fire despitereview_decision: REVIEW_REQUIRED. - Row 3 (deletion in high-risk paths): all
high_risk_reasonsentries are(added)— newschemas/cache/3.2.0-rc.0/**files. No(deleted). - Rows 4/5 (medium findings): none present.
- Row 6 (sticky escalate): no prior decision.
- Row 7 (no-auto-approve team): no team match.
- Row 8 (≥3 medium): zero medium findings.
- Row 9: approve.
The high_risk flag is true only because the PR scaffolds new schema-cache files (all (added)), which per the change-kind guidance is normal additive work, not escalation-worthy. Reviewer confirms: rc version feature-gates in media_buy_actions.py correctly extend to -rc.\d+, the new reporting_core_lifecycle_probe controller scenario validates/dispatches with test coverage, and the generated/schema/packaging changes are clean regeneration paired with the ADCP_VERSION bump. No public export removed, no required/optional flips — feat: is the correct semver signal.
|
@rachitm022 @andybevan-scope3 RC.0 adoption is fully green and auto-merge is armed. A human approval from someone other than the last pusher is the remaining gate when one of you has a moment. |
Summary
3.2.0-rc.0schema bundle (SHA-2567c1a6fd428656d9f5559f5ce848423f4f6e8cfd1e9f9b8657fdd6b5e1a4038fe)reach_unitdelivery simulation fieldValidation
make validate-generatedThe Python package remains on its managed prerelease line; the release workflow will produce the next SDK beta after this merges.