Skip to content

feat(protocol): adopt AdCP 3.2 rc.0 - #1123

Merged
bokelley merged 1 commit into
mainfrom
feat/adcp-3.2-rc.0
Sep 4, 2026
Merged

feat(protocol): adopt AdCP 3.2 rc.0#1123
bokelley merged 1 commit into
mainfrom
feat/adcp-3.2-rc.0

Conversation

@bokelley

@bokelley bokelley commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • adopt the signed 3.2.0-rc.0 schema bundle (SHA-256 7c1a6fd428656d9f5559f5ce848423f4f6e8cfd1e9f9b8657fdd6b5e1a4038fe)
  • regenerate Python models for product identity, daypart timezone, overlay, flat-rate, and compliance additions
  • support RC protocol strings in media-buy action feature gates
  • add the RC reporting lifecycle controller contract and reach_unit delivery simulation field

Validation

  • make validate-generated
  • full pytest: 7,606 passed, 42 skipped, 1 xfailed
  • targeted pre-commit hooks: black, ruff, mypy, adopter type checks, bandit, and file checks
  • clean wheel/sdist audit: RC schemas included; beta.11 schemas absent

The Python package remains on its managed prerelease line; the release workflow will produce the next SDK beta after this merges.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean additive AdCP 3.2 beta.11 → rc.0 adoption.

Checked against the decision table top-down:

  • Rows 1 (critical/high): no findings — none present.
  • Row 2 (gated_paths): gated_paths: false, so does not fire despite review_decision: REVIEW_REQUIRED.
  • Row 3 (deletion in high-risk paths): all high_risk_reasons entries are (added) — new schemas/cache/3.2.0-rc.0/** files. No (deleted).
  • Rows 4/5 (medium findings): none present.
  • Row 6 (sticky escalate): no prior decision.
  • Row 7 (no-auto-approve team): no team match.
  • Row 8 (≥3 medium): zero medium findings.
  • Row 9: approve.

The high_risk flag is true only because the PR scaffolds new schema-cache files (all (added)), which per the change-kind guidance is normal additive work, not escalation-worthy. Reviewer confirms: rc version feature-gates in media_buy_actions.py correctly extend to -rc.\d+, the new reporting_core_lifecycle_probe controller scenario validates/dispatches with test coverage, and the generated/schema/packaging changes are clean regeneration paired with the ADCP_VERSION bump. No public export removed, no required/optional flips — feat: is the correct semver signal.

@bokelley
bokelley enabled auto-merge (squash) September 3, 2026 20:10

bokelley commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@rachitm022 @andybevan-scope3 RC.0 adoption is fully green and auto-merge is armed. A human approval from someone other than the last pusher is the remaining gate when one of you has a moment.

@bokelley
bokelley disabled auto-merge September 4, 2026 00:02
@bokelley
bokelley merged commit 6314f45 into main Sep 4, 2026
27 checks passed
@bokelley
bokelley deleted the feat/adcp-3.2-rc.0 branch September 4, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant