fix(server): sanitize legacy adapter failures - #1127
Merged
Conversation
bokelley
enabled auto-merge (squash)
September 5, 2026 08:56
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean, well-scoped error-disclosure fix for the legacy adapter.
Checked:
- No Critical/High/Medium findings reported by the reviewer.
- Legacy-adapter exception text is now routed through
legacy_adapter_task_error, which fail-closes: only an explicit opt-inLegacyAdapterValidationErroron the request phase surfaces its author-written message; all other failures return fixed public text with the traceback logged operator-side only. This is a security-hardening improvement (prevents internal exception detail leaking onto the wire). - Dual-transport (MCP + A2A) and dual-phase test coverage confirms the sentinel never reaches the wire; two new test files back the new branches.
Gate checks:
gated_pathsis false, so row 2 does not apply despitereview_decision: REVIEW_REQUIRED.high_riskis true, but reasons are(added)/(modified)with no medium-or-higher findings, so rows 3–5 do not fire. New-file additions and clean modifications on high-risk paths are presumed safe absent findings.- No no-auto-approve team match (row 7 n/a). Fewer than three medium findings (row 8 n/a).
Falls through to row 9 → approve.
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #1126
Open workspace in Conductor