Skip to content

feat(v3-ref-seller): enable server-side ValidationHookConfig at boot #387

@bokelley

Description

@bokelley

Context

The v3 reference seller does not pass validation=ValidationHookConfig(requests="strict", responses="strict") to serve(), so the SDK's request/response validators are not run. Bugs like the recent pricing_options shape conformance issue would have been caught immediately had validation been on.

Refs:

  • examples/v3_reference_seller/src/app.py (where serve() is invoked)
  • src/adcp/server/serve.py (ValidationHookConfig parameter)

Acceptance Criteria

  • V3 reference seller passes validation=ValidationHookConfig(requests="strict", responses="strict") to serve() by default
  • README documents the trade-offs: strict mode rejects out-of-spec requests/responses at the boundary; "warn" is the relaxed alternative
  • An env var or config knob lets adopters drop to "warn" if they need to tolerate older buyers/sellers during a rollout
  • Smoke test: an intentionally malformed request is rejected with a spec-shaped error response in strict mode
  • Smoke test: same malformed request produces a warning (logged, but processed) in warn mode

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions