feat(testing): docstring-vs-code consistency test

[bokelley]

Context

client.py:381-388 claimed PYTHON_ENV / ENV / ENVIRONMENT env vars were honored; only ADCP_ENV was. Docstring was stale for months.

Add a test that AST-parses public method docstrings, looks for env-var references, then greps the code for matching os.environ.get(...) calls. Drift = test failure.

Acceptance Criteria

• New tests/test_docstring_consistency.py
• AST-parses public method docstrings in src/adcp/
• Extracts env-var references and verifies a matching os.environ.get(...) call exists
• CI fails on drift

Files

• src/adcp/client.py:381-388 (the original drift)

[bokelley]

Triage

Classification: Feature request (new test)
Bucket(s): client
Status: drafting-pr
Milestone: omitted

What the experts said:

• code-reviewer: approved — test logic correct; raw-text scan limitation and PORT coverage gap are documented known limitations; no blockers
• dx-expert: approved after fixes — initial blockers (greedy suffix-match regex, missing ±1-line sliding window for ADCP_ENV, standalone overrides false-positive risk, bare ignored? suppression) all resolved before opening the PR

My take: Straightforward new test file, fully non-breaking. Two-step backtick-span extraction + word-boundary SCREAMING_CASE search avoids the greedy-regex suffix issue; ±1-line window catches the exact drift pattern from client.py:382-383 where ADCP_ENV and flips land on adjacent lines. Drafting PR #440.

Draft PR: #440

---

Triaged by Claude Code. Session: https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}

---

Generated by Claude Code