codemod: flag MediaBuyStatus.pending_activation split + required-field omissions

[bokelley]

From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, items #3 and #4).

Two semantic changes in 4.x that the codemod doesn't catch — both surfaced as runtime test failures after collection was otherwise clean:

1. MediaBuyStatus.pending_activation split

Removed in 4.x and split into pending_start | pending_creatives based on cause. Surfaces as AttributeError: type object 'MediaBuyStatus' has no attribute 'pending_activation' at runtime.

Batch-replaced 9 files mechanically with pending_start to unblock collection, then immediately added a TODO(...) because the correct mapping is per-call-site (needs_creatives → pending_creatives; schedule-future → pending_start).

Ask: flag MediaBuyStatus.pending_activation references with a "use pending_start | pending_creatives based on cause" pointer, OR ship a deprecation alias mapping to pending_start with a DeprecationWarning for one minor.

2. idempotency_key becoming required on CreateMediaBuyRequest

The first runtime test failure after a clean collection was a Pydantic ValidationError: idempotency_key Field required. The codemod doesn't flag request constructions that omit now-required fields. This is one of ~600 legacy-test failures still pending.

Ask: codemod or pytest-level warning hook that flags request constructions missing fields that became required between two schema versions. Even a per-construction warning would beat per-test debugging.

Notes

The required-field detection is a bigger lift (needs schema diff between two adcp versions). The pending_activation flagger is a one-off enum mapping. Either ships value independently.

[bokelley]

Triage

Classification: Feature request
Bucket(s): client
Status: drafting-pr
Milestone: (omitted — no version target named)

What the experts said:

• dx-expert: REMOVED_ENUM_VALUES dict (separate from REMOVED_ATTRIBUTE_ACCESSES) is the right hook; hint is actionable with valid_actions reference; flag_enum_value as a distinct kind is correct for JSON consumers
• code-reviewer: regex is correct (re.escape handles the dot; \b anchors suffix), non-breaking, no blockers

My take: Item 1 (pending_activation flag) is a clean addition to the existing codemod — shipped in #523. Item 2 (required-field detection) is deferred: text-match has an unacceptable false-negative rate on multi-line constructors and **kwargs unpacking; an AST-based pass is the right architecture when the time comes.

Shipped in #523: flag_enum_value finding kind + REMOVED_ENUM_VALUES dict with MediaBuyStatus.pending_activation → hint naming both replacement values and pointing to valid_actions as the runtime discriminator.

Still pending (item 2): AST-based required-field detection for idempotency_key on CreateMediaBuyRequest. Leaving issue open as tracking surface.

---

Triaged by Claude Code. Session: https://claude.ai/code/session_01294Agd3ZTguC1drs5Beous

---

Generated by Claude Code