Skip to content

docs(skills): round-8 DX polish — scope seller, self-contain signals#242

Merged
bokelley merged 1 commit intomainfrom
bokelley/skills-round8-polish
Apr 20, 2026
Merged

docs(skills): round-8 DX polish — scope seller, self-contain signals#242
bokelley merged 1 commit intomainfrom
bokelley/skills-round8-polish

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

Summary

Bundles two round-8 validation findings into one docs-only PR. Closes #215 and #216.

#215 — seller skill scoping (Option A)

Rewrite the Validation section of `build-seller-agent/SKILL.md` to explicitly scope the skill to the 9 core `media_buy_seller` scenarios. Round-8 observed fresh users seeing `WARN: partial` on the full storyboard and doubting the skill. Adds a track-by-track breakdown of the ~13 advanced scenarios the skill deliberately doesn't teach, with pointers for wiring them up independently (governance, creative lifecycle, measurement, targeting persistence, state machine, delivery).

#216 — signals skill self-containment

Inline minimal `sync_accounts` + `sync_governance` bodies into `build-signals-agent/SKILL.md`'s Governance Tracks section (~25 lines). Drops the "see `examples/seller_agent.py`" cross-reference — the last external jump in an otherwise self-contained skill.

Why bundle

Both findings come from the same round-8 validation report, both are skill-polish docs, both touch `skills/*/SKILL.md` — zero risk of merge conflicts, identical review context, and one PR is less process than two for ~55 lines of docs.

Test plan

  • No code changes — docs only
  • Pre-commit passes (trim whitespace, end-of-files, merge-conflict check)
  • Visual review: seller skill's new Validation subsection reads cleanly
  • Visual review: signals skill Governance section is now self-contained

🤖 Generated with Claude Code

Bundles two round-8 validation findings. Pure docs changes to
skills/*/SKILL.md; no code surface.

#215 — seller skill scoping (Option A)
Rewrite the Validation section of build-seller-agent/SKILL.md to
scope the skill's promise explicitly to the 9 core media_buy_seller
scenarios. Fresh users read "9/9 passing" then see "WARN: partial"
on the full storyboard and doubt the skill — this section explains
that the advanced tracks (governance_denied, pending_creatives,
measurement_terms, inventory_list_targeting, invalid_transition,
delivery_reporting/simulate_and_verify) require additional stubs
this skill deliberately doesn't teach, and points to the doc or
handler pattern for each.

#216 — signals skill self-containment
Inline the minimal sync_accounts + sync_governance bodies into
build-signals-agent/SKILL.md's Governance Tracks section. Drops the
"see examples/seller_agent.py" cross-reference — the last external
jump in an otherwise self-contained skill. Round-8 observed
signals went from 12 min + 3 attempts to 4 min + 1 attempt after
round-7's section addition; this closes the remaining ~2-minute
tax of cross-referencing the seller example.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skill(seller): scope skill to actual teaching or add stubs for the 20+ validator scenarios

1 participant