Skip to content

fix(agents): triage already-engaged + ship-more (missed in #259)#262

Merged
bokelley merged 2 commits intomainfrom
bokelley/triage-already-engaged-and-ship-more
Apr 23, 2026
Merged

fix(agents): triage already-engaged + ship-more (missed in #259)#262
bokelley merged 2 commits intomainfrom
bokelley/triage-already-engaged-and-ship-more

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

Summary

Two commits intended for #259 that landed on the branch after the merge button was clicked — carrying them forward here as a follow-up.

1. Already-engaged check (mirror of adcontextprotocol/adcp#2957)

Silent-defer when the issue is assigned to a repo member, has an open PR referencing it, or has a repo-member comment in the last 7 days. Prevents competing analysis on work a human is already engaged on (the bot can't see Conductor workspaces / local drafts / Slack).

2. Ship-more default (mirror of adcontextprotocol/adcp#2958)

Default flipped: Execute when outcome is clear; Flag only for genuine ambiguity or breaking changes. Drops <150 line scope cap + classification-only-Bug-or-Doc gate. Adds non-breaking-vs-breaking as the primary binary.

For this repo specifically:

  • Non-breaking (Execute): new optional params / methods / handler methods / Pydantic fields, new examples / docs / tests, typo / link fixes, wording clarifications
  • Breaking (Flag): removing/renaming public symbols, signature changes, Pydantic required flips, default changes, dep bumps on pinned deps (a2a-sdk, httpcore, datamodel-code-generator)

Scope and author association are NOT gates. CODEOWNERS + human review still gate merge.

Test plan

  • Merge
  • Fire the adcp-client-python routine when it's set up; confirm new mix (more Execute, less Flag on non-breaking issues)

🤖 Generated with Claude Code

bokelley and others added 2 commits April 23, 2026 18:20
Mirror of adcontextprotocol/adcp#2957:

1. Already-engaged check before expert consultation. Silent-defer
   when the issue is assigned to a repo member, has an open PR
   referencing it, or has a repo-member comment in the last 7
   days — a human is probably already working on it in a
   Conductor workspace / drafts / Slack and the bot's synthesis
   would pre-frame their thinking.

2. Tighten "never create labels" rule: must run gh label list
   first, apply only names returned, never POST to /labels, default
   not-apply on uncertainty. Missing bucket labels go in the
   comment body plus the run summary.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mirror of adcontextprotocol/adcp#2958. Flip the default from "flag
unless obviously a small bug" to "execute unless breaking or
ambiguous."

- Drop <150 line scope cap
- Drop classification-only-Bug-or-Doc gate
- Replace with single non-breaking-vs-breaking binary
- "When in doubt: Execute" mantra (inverted on adcp-go — TEE
  posture means when in doubt, Flag)

CODEOWNERS + human review still gate every merge. Generated files,
pinned deps, TEE-bound paths (adcp-go) still always Flag.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@bokelley bokelley marked this pull request as ready for review April 23, 2026 22:22
@bokelley bokelley merged commit ca42d29 into main Apr 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant