Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions .agents/routines/triage-prompt.md
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,9 @@ unit tests pass.
2. **If build or tests fail:** read the errors, fix the code,
re-run. Cap at **2 build→fix iterations.** If still failing,
abandon the PR and Flag for human review with the build log
in the comment.
in the comment. **Do not declare "approved" in the pre-PR
review block while build is red** — that's a trust-eroding
signal (per adcp#3121).
3. Do **not** skip tests locally because "CI will run them." The
point of this gate is to not ship known-broken code even as a
draft, because (a) review noise, (b) a human reviewer may
Expand Down Expand Up @@ -395,8 +397,39 @@ have read the diff before a human reviewer does.
- Status: **draft**
- Title: conventional-commits (`fix(adcp): …`, `docs(adcp): …`) —
release-please reads titles for versioning
- Body: `Closes #N`, summary, what-tested, **Pre-PR review** block,
`Session:` link
- Body, in order:
- `Closes #N`
- One-paragraph summary
- What-tested list (pytest / mypy / ruff / black results)
- **Pre-PR review** block with both experts' one-line sign-off
- **Triage-managed PR block** — append this verbatim before the
`Session:` link so reviewers know the iteration policy:

```
> **Triage-managed PR.** This bot does not currently iterate on
> review comments or PR conversation threads (only on the source
> issue). To unblock:
>
> - **Push fixup commits directly:** `gh pr checkout <num>` →
> fix → push.
> - **Or re-trigger:** comment `/triage execute` on the source
> issue.
>
> See [adcp#3121](https://github.com/adcontextprotocol/adcp/issues/3121)
> for context.
```
- `Session: https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}`
- **After `gh pr create` succeeds**, label the PR `claude-triaged`
so it's searchable from PR list views (mirrors the issue label):

```
gh pr edit <PR#> --repo <owner>/<repo> --add-label claude-triaged
```

(Don't apply `claude-triaging` to the PR — that label is the
routine's "I'm working on this **issue**" signal, not a PR
ownership marker.)

- Before pushing:
- `pytest` on the subset touching your change (don't run full
slow integration tier unless relevant)
Expand Down
Loading