Skip to content

chore(sync-schemas): allow cosign verify against refs/tags/* for forward-compat #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
May 1, 2026
+7 −2
Merged

chore(sync-schemas): allow cosign verify against refs/tags/* for forward-compat #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/sync_schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,15 @@
USER_AGENT = "adcp-python-sdk/3.0"

# Sigstore keyless verification identity. Must match the upstream release
# workflow — see adcontextprotocol/adcp#2273.
# workflow — see adcontextprotocol/adcp#2273. Accepts any branch or tag ref;
# the trust gate is upstream `release.yml`'s `on.push.branches` allowlist
# (currently main, 3.0.x, 2.6.x), which is what determines which refs can
# produce a signature in the first place. `refs/tags/*` is forward-compat
# for any future post-tag re-signing flow. Aligned with adcp-client (TS) and
# adcp-go, which both use the same `refs/(heads|tags)/.*` pattern.
COSIGN_IDENTITY_REGEX = (
r"^https://github\.com/adcontextprotocol/adcp/"
r"\.github/workflows/release\.yml@refs/heads/.*$"
r"\.github/workflows/release\.yml@refs/(heads|tags)/.*$"
)
COSIGN_OIDC_ISSUER = "https://token.actions.githubusercontent.com"

Expand Down
Loading