Skip to content

docs(migration): note 161 figure is v4.0 worst case #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bokelley wants to merge 1 commit into from
Closed

docs(migration): note 161 figure is v4.0 worst case #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions MIGRATION_v3_to_v4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ the whole codebase. salesagent re-exported through `src/core/schemas/_base.py`
during pytest collect-only**, and stubbing it revealed the next ~140-test
cascade from `BrandManifest`, then the next from the `generated_poc` reach-ins.

> **The 161 figure is the worst case at v4.0 release.** A salesagent
> re-run against v4.3+ (after expanded type aliases, `pending_activation`
> codemod flagger, and the smaller-blast-radius
> `_base.py`-cascade-warning landed) hit 141 codemod findings and ~36
> collection errors — markedly less than the worst-case framing above.
> Expect the lower number on v4.3+ checkouts; the worst-case story is
> preserved here so adopters who copy salesagent's pre-v4.3 pattern know
> what to triage first.

The codemod's static finding count understates this by 100x+. To minimize the
felt blast radius, work in this order:

Expand Down
Loading