fix(codegen): preserve regenerated response aliases#824
Conversation
|
Tried to update this branch against current main, but GitHub reports conflicts. I confirmed the conflicts are in generated/type-codegen areas touched since this branch was cut: |
5dbb746 to
97dfba3
Compare
bokelley
left a comment
There was a problem hiding this comment.
Reviewed local follow-up changes; checks are green.
bokelley
left a comment
There was a problem hiding this comment.
Reviewed latest follow-up changes; CI is green.
|
Closed as superseded by #854, which carried the same patch stack on an in-repository branch so CodeQL and Argus could run under normal branch protection. |
Pull request was closed
Summary
Refs #822.
This rebuilds the codegen response-alias fix on current
mainafter the earlier branch conflicted with the AdCP 3.1 generated/type-codegen changes.The change keeps the clean-regeneration path working for restored response aliases:
ProtocolEnvelopeimports afterpost_generate_fixes.pyrestores manual response armsTypeAliasassignments when consolidating generated exports_g.FooResponsefallback lookups inaliases.pyTesting
uv run --extra dev python scripts/generate_types.pyuv run --extra dev python -c "from adcp.types import _generated; from adcp.types import aliases; print('import-ok')"uv run --extra dev pytest tests/test_code_generation.py tests/test_asset_aliases_stable.py tests/test_schemas_version_pin.py -q --tb=shortuv run --extra dev ruff check --ignore E501 scripts/consolidate_exports.py scripts/post_generate_fixes.py src/adcp/types/aliases.py tests/test_code_generation.pygit diff --checkFull-suite note:
uv run --extra dev pytest -q --tb=shortcompleted with one unrelated wall-clock boundary failure intests/test_pg_idempotency_backend.py::test_delete_expired_defaults_to_wall_clock(5277 passed, 38 skipped, 9 deselected, 1 xfailed, 1 failed). Re-running that single test passed:uv run --extra dev pytest tests/test_pg_idempotency_backend.py::test_delete_expired_defaults_to_wall_clock -q --tb=short.