fix(types): add UpdateMediaBuyResponse1 ergonomic coercion#857
Closed
sangilish wants to merge 1 commit into
Closed
fix(types): add UpdateMediaBuyResponse1 ergonomic coercion#857sangilish wants to merge 1 commit into
sangilish wants to merge 1 commit into
Conversation
Contributor
|
Superseded by #864, which mirrors this follow-up onto a repo-owned branch so the required base-repo checks can run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #854.
This extends the generated ergonomic coercion pass to include the update-media-buy success response arm.
UpdateMediaBuySuccessResponse/UpdateMediaBuyResponse1now gets the same package-subclass andmedia_buy_statusstring coercion treatment thatCreateMediaBuyResponse1already had.What changed
UpdateMediaBuyResponse1toscripts/generate_ergonomic_coercion.pyresponse analysis.src/adcp/types/_ergonomic.pysoaffected_packages,packages, andmedia_buy_statusare patched at import time.media_buy_statuscoercion.Testing
uv run --extra dev pytest tests/test_type_coercion.py tests/test_code_generation.py -q --tb=shortuv run --extra dev pytest tests/test_type_aliases.py tests/test_public_api.py tests/type_checks -q --tb=shortuv run --extra dev pytest -q --tb=shortuv run --extra dev ruff check scripts/generate_ergonomic_coercion.py src/adcp/types/_ergonomic.py tests/test_type_coercion.pyuv run --extra dev mypy src/adcp/typesuv run --extra dev mypy src/adcpGitHub CI: all normal CI jobs are green, including Python 3.10-3.13, Postgres conformance, schema validation, downstream import smoke, storyboards, IPR, and GitGuardian.
Note: full
uv run --extra dev ruff checkstill reports unrelated existing lint failures in tests outside this PR's touched files, so I used the targeted ruff command above for the changed files.CI note: the only failing GitHub check is
code_review(Argus). It fails before review execution while minting the GitHub App token because the app client id / app id secret is unavailable in this fork PR context. This is not a code/test failure in this branch.