ci: use release-please manifest prerelease config#877
Merged
Conversation
There was a problem hiding this comment.
LGTM. Follow-ups noted below. Manifest mode is the right shape — the existing release-please-config.json already declares versioning: prerelease + prerelease-type: beta, and release-type: python as an action input was bypassing it entirely.
Things I checked
release-please-action@v5invocation: withconfig-file+manifest-fileand norelease-type, the action takes theManifest.fromManifestpath and honors the config file. Settingrelease-typewould have flipped it back toManifest.fromConfig, which ignores the config file — that was the bug.- Downstream plumbing:
steps.release.outputs.prs_createdand therelease-please--branches--mainbranch name are populated by release-please core, not the input mode. TheNormalize release PR pyproject prerelease versionstep still gates and runs identically. - Bump math at
6.3.0-beta.4:feat:andfix:both route throughbumpPrerelease("beta.4")→6.3.0-beta.5. Matches the docs. release-please-config.jsonand.release-please-manifest.jsonare syntactically valid and reachable (PR'sdebug-configevidence).
Follow-ups (non-blocking — file as issues)
feat!:behavior is undocumented and contradicts the new copy.RELEASING.md:187says "keep the base version fixed and increment only the beta counter." TracingPrereleaseMajorVersionUpdate.bumpfor6.3.0-beta.4(minor=3, so thepatch === 0 && minor === 0guard is false): a breaking change exits the beta line and produces plain7.0.0, dropping the prerelease label entirely. Narrow the claim to non-breaking commits and add a one-liner on the breaking-change escape hatch.- No documented path from
6.3.0-beta.Nto6.3.0stable. Withversioning: prereleasethe counter only increments. Graduation needs a manualRelease-As: 6.3.0footer (or a manifest edit). This will be the next support question — worth a 3-line "Graduating a beta" subsection. bump-minor-pre-major: true/bump-patch-for-minor-pre-major: falseinrelease-please-config.jsonare inert at major=6. Pre-existing, not introduced here, but they imply they're shaping current behavior. Worth deleting in a sweep.- Validation evidence covers parsing, not behavior.
debug-configconfirms the config is reachable; it doesn't simulate afeat:producingbeta.5. Arelease-pr --dry-runagainst a synthetic commit would be stronger. Notable, because the very next release PR is the actual smoke test.
Minor nits (non-blocking)
PYPI_SETUP.md:78-80attributes the behavior to "manifest-mode config" — the actual cause isversioning: prerelease. Implementation detail vs. user-facing rule. Optional reword.PYPI_SETUP.md:77still readsfeat!:→ major bump unconditionally. With the new bullet directly underneath, the two lines now have a subtle inconsistency on the beta line. Same fix as theRELEASING.mdfollow-up.
Approving on the strength of the mechanical change being correct and the downstream pipeline being undisturbed. The doc tightening can land in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please-config.jsonis honored.versioning: prerelease.beta.Ninstead of bumping the base minor version.Why
The workflow passed
release-type: pythondirectly to the action. In that mode, Release Please does not use the advanced manifest configuration, so the beta prerelease strategy was not reliably driving release PR versions.Validation
python3 -c 'import json; json.load(open("release-please-config.json")); json.load(open(".release-please-manifest.json"))'ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release-please.yml")'git diff --checknpx release-please debug-config --repo-url adcontextprotocol/adcp-client-python --target-branch main --local --local-path .confirmed manifest config parses withversioning: prereleaseand current version6.3.0-beta.4.