fix: address three open issues (#359, #360, #361)#369
Merged
Conversation
- getAllPlatformTypes() returns { id, label } objects instead of bare strings
- buildStaticInlineCreative() includes required creative_id field
- signals scenario uses spec field names (signal_agent_segment_id, destinations)
- request normalizer maps deprecated signal_id, destination, options fields
- adds normalizer test coverage for all new activate_signal shims
Closes #359, closes #360, closes #361
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Keep getAllPlatformTypes() returning PlatformType[] (non-breaking)
- Add getPlatformTypesWithLabels() for callers needing { id, label }
- Add warnOnce for options stripping in activate_signal normalizer
- Add scoping tests (normalizer shims only apply to activate_signal)
- Add combined normalization test for all deprecated fields together
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Test destinations now use spec-compliant Destination type with type discriminator and correct field names (account vs account_id). This gives TypeScript users compile-time protection against field name drift. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAllPlatformTypes()now returns{ id, label }objects instead of bare strings, so callers can discover valid platform type values with their labelsbuildStaticInlineCreative()includes requiredcreative_idfield per creative-asset.json specsignal_agent_segment_id,destinationsarray) and request normalizer maps deprecated aliases (signal_id,destinationsingular,options)Test plan
signal_id → signal_agent_segment_id,destination → destinations, andoptionsstrippinggetAllPlatformTypestests verify each entry hasidandlabelCloses #359, closes #360, closes #361
🤖 Generated with Claude Code