Skip to content

feat: behavioral compliance validations for storyboards#507

Merged
bokelley merged 3 commits intomainfrom
bokelley/compliance-storyboards
Apr 15, 2026
Merged

feat: behavioral compliance validations for storyboards#507
bokelley merged 3 commits intomainfrom
bokelley/compliance-storyboards

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

@bokelley bokelley commented Apr 13, 2026

Summary

Closes #497. Storyboard validations were mostly schema-only — agents could skip brand resolution, ignore property lists, or bypass content standards and still pass existing tests. This adds behavioral compliance checks and fixes request builder inconsistencies.

Storyboard validations:

  • Brand rights: verify resolved identity data (brand_id match, names present), reject invalid brand IDs, validate creative approval decisions, enforce expired campaigns and nonexistent grants
  • Property governance: assert compliant: true/false delivery verdicts, add enforcement phase with authorized and unauthorized publisher tests, explicit context_outputs for property_list_id, reorder delete after validation phases
  • Content standards: assert calibration verdict, test must-rule violations (verdict: fail), test policy version changes with re-calibration, strengthen delivery validation checks

Request builder fixes:

  • get_brand_identity / get_rights: respect sample_request.brand_id instead of always defaulting to test.example
  • All property list builders (get, update, list, delete): pass brand consistently — fixes session key mismatch where create used one brand but subsequent operations used default

MCP Tasks error recovery:

  • Recover adcpError content from SDK error events by fetching task result (JSON-parsed, not string-matched)

Test plan

  • All tests pass (2,972 pass, 0 fail)
  • All CI checks green (12/12)
  • Code review: Must Fix items addressed (phase ordering, JSON parsing)
  • Security review: clean — no secrets, injection vectors, or unsafe domains

🤖 Generated with Claude Code

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Apr 15, 2026

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bokelley bokelley force-pushed the bokelley/compliance-storyboards branch 3 times, most recently from 64693d2 to 185d965 Compare April 15, 2026 08:27
Closes #497. Storyboard validations were mostly schema-only — agents
could skip brand resolution, ignore property lists, or bypass content
standards and still pass existing tests.

Brand rights: verify resolved identity data (brand_id match, names
present), reject invalid brand IDs, validate creative approval
decisions, enforce expired campaigns and nonexistent grants.

Property governance: assert compliant/non-compliant delivery verdicts,
add enforcement phase with authorized and unauthorized publisher tests,
fix context_outputs for property_list_id propagation, use records
format per spec.

Content standards: assert calibration verdict, test must-rule violations,
test policy version changes with re-calibration, strengthen delivery
validation with summary and results checks.

Request builders: get_brand_identity and get_rights respect
sample_request.brand_id; all property list builders pass brand
consistently (fixes session key mismatch).

MCP Tasks: recover adcpError content from SDK error events by fetching
task result when taskId is available.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bokelley bokelley force-pushed the bokelley/compliance-storyboards branch from 185d965 to 309126f Compare April 15, 2026 08:43
bokelley and others added 2 commits April 15, 2026 22:54
…toryboards

# Conflicts:
#	src/lib/types/core.generated.ts
#	src/lib/types/schemas.generated.ts
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bokelley bokelley merged commit 1395e20 into main Apr 15, 2026
13 checks passed
@bokelley bokelley deleted the bokelley/compliance-storyboards branch April 15, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance storyboard gaps: brand resolution, property auth, content standards

1 participant