docs(skills): fix typed SDK examples#146
Merged
Merged
Conversation
There was a problem hiding this comment.
LGTM. Clean follow-up that pulls the skill examples back onto the typed SDK and the required-field reality.
Things I checked
LogEventResponsesignature inREADME.mdandskills/build-retail-media-agent/SKILL.mdmatchesadcp/responses.go:231—(received, processed int, matchQuality float64, sandbox bool).BuildCreativeRequest.TargetFormatIDis*FormatRefatadcp/types_gen.go:2431; the rename fromFormatIDtoTargetFormatIDinskills/build-creative-agent/SKILL.mdis the right shape.CreativeManifest.FormatIDis a typedFormatRefatadcp/types_gen.go:1900, notmap[string]any— soinput.CreativeManifest.FormatID.IDreplaces the old double type-assert correctly.Product.PublisherPropertiesandProduct.ReportingCapabilitiesare both required on the wire — noomitemptyatadcp/types_gen.go:1785and:1798. The seller skill's prior "publisher_propertiesis optional" line was drift; this fix is schema-honest.- Validation-status flip on generative-seller and retail-media aligns with
README.md:54-55, which already lists both as9/9 validated. Docs catching up to README, not the other way around. - Conventional commit type
docs(skills):is correct — no wire-path symbols removed, no breaking marker needed.
Follow-ups (non-blocking — file as issues)
skills/build-creative-agent/SKILL.mdbuild path still constructs the outbound manifest asmap[string]any{"format_id": ..., "assets": ...}even thoughinput.CreativeManifestis now typed. Worth a pass to drop the map intermediate and pass the typed manifest through, if the downstream serving-tag builder takes one. Not blocking — the wire shape is unchanged.- The seller-agent common-mistakes row collapses three required fields into one bullet ("Missing
publisher_properties,format_ids, orreporting_capabilities"). Reads fine; a future pass could split them so an adopter grepping for a single field name still hits the row.
Safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from the expert pass after #142:
publisher_propertiesandreporting_capabilitiesCreativeManifestandBuildCreativeRequest.TargetFormatIDLogEventResponsedocs to includematchQualityValidation
git diff --checkRelated
Generator replacement/evaluation tracked in #145.