Skip to content

docs(skills): fix typed SDK examples#146

Merged
bokelley merged 1 commit into
mainfrom
bokelley/generator-eval
May 26, 2026
Merged

docs(skills): fix typed SDK examples#146
bokelley merged 1 commit into
mainfrom
bokelley/generator-eval

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

Summary

Follow-up from the expert pass after #142:

  • fixes seller/generative/retail product examples to include required publisher_properties and reporting_capabilities
  • updates creative-agent snippets to use typed CreativeManifest and BuildCreativeRequest.TargetFormatID
  • fixes LogEventResponse docs to include matchQuality
  • aligns generative/retail skill validation status with README

Validation

  • git diff --check
  • source/docs inspection only; markdown/example-only changes

Related

Generator replacement/evaluation tracked in #145.

Copy link
Copy Markdown

@aao-ipr-bot aao-ipr-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean follow-up that pulls the skill examples back onto the typed SDK and the required-field reality.

Things I checked

  • LogEventResponse signature in README.md and skills/build-retail-media-agent/SKILL.md matches adcp/responses.go:231(received, processed int, matchQuality float64, sandbox bool).
  • BuildCreativeRequest.TargetFormatID is *FormatRef at adcp/types_gen.go:2431; the rename from FormatID to TargetFormatID in skills/build-creative-agent/SKILL.md is the right shape.
  • CreativeManifest.FormatID is a typed FormatRef at adcp/types_gen.go:1900, not map[string]any — so input.CreativeManifest.FormatID.ID replaces the old double type-assert correctly.
  • Product.PublisherProperties and Product.ReportingCapabilities are both required on the wire — no omitempty at adcp/types_gen.go:1785 and :1798. The seller skill's prior "publisher_properties is optional" line was drift; this fix is schema-honest.
  • Validation-status flip on generative-seller and retail-media aligns with README.md:54-55, which already lists both as 9/9 validated. Docs catching up to README, not the other way around.
  • Conventional commit type docs(skills): is correct — no wire-path symbols removed, no breaking marker needed.

Follow-ups (non-blocking — file as issues)

  • skills/build-creative-agent/SKILL.md build path still constructs the outbound manifest as map[string]any{"format_id": ..., "assets": ...} even though input.CreativeManifest is now typed. Worth a pass to drop the map intermediate and pass the typed manifest through, if the downstream serving-tag builder takes one. Not blocking — the wire shape is unchanged.
  • The seller-agent common-mistakes row collapses three required fields into one bullet ("Missing publisher_properties, format_ids, or reporting_capabilities"). Reads fine; a future pass could split them so an adopter grepping for a single field name still hits the row.

Safe to merge.

@bokelley bokelley merged commit 2edd369 into main May 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant