docs(contributing): align changeset exemptions with .changeset/README.md (Argus smoke test)#21
Merged
Merged
Conversation
Adds the Argus AI PR review workflow + reviewer prompt, adapted for the Java SDK harness. - .github/workflows/ai-review.yml — runs on every non-draft, non- dependabot PR. Skippable-rerun check tuned for Java/Gradle trivial paths (.changeset/*, docs/**, **/src/test/**, *.lockfile, package-lock.json). ROADMAP.md, CLAUDE.md, and specs/** are treated as non-trivial (governance). - .github/ai-review/expert-adcp-reviewer.md — reviewer prompt in bokelley voice. MUST FIX rules rewritten around what applies here: D1-D21 drift (called out by D-number), the *Request/*Response naming invariant, @nullable vs Optional, hand-edits to **/build/generated/**, wire-shape change without a major changeset, lockfile drift. Domain-expert triggers map to this repo's modules (codegen plumbing, adcp-server signing/auth, schema-bundle fetcher, Spring Boot starter, etc.). Posts as github-actions[bot] via the default GITHUB_TOKEN. Per D21, branch protection still requires one code-owner approving review — an Argus --approve is informational and runs alongside human review, not in place of it. When the foundation provisions a per-repo GitHub App, swap to an App-installation token and Argus approvals will start counting toward branch protection. External-fork PRs receive a read-only GITHUB_TOKEN by event design; Argus is effectively first-party only until the App lands. Required secret: ANTHROPIC_API_KEY. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CONTRIBUTING.md listed only "refactors, docs, or test-only" as exempt; .changeset/README.md also exempts chore: / ci: commits. Drift caused by independent edits to the two files. Argus smoke test for #20 — a docs-only change that should classify as docs-only, skip subagent delegation, and post `--approve`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM. One-line alignment with .changeset/README.md:11-14, which already lists chore: / ci: as exempt.
Things I checked
CONTRIBUTING.md:87now matches.changeset/README.md:11-14— the source of truth for the four exempt categories.- D18-aligned: changeset policy itself unchanged. This is documentation catching up to the policy, not a policy shift.
- No changeset required —
docs:commits are themselves on the exemption list. Recursion holds. - The other two files in the diff (
.github/workflows/ai-review.yml,.github/ai-review/expert-adcp-reviewer.md) belong to #20 and aren't part of this PR's commits. Reviewed there. - Test plan: four unchecked boxes, all of which describe Argus's behavior reviewing this PR — they can only resolve after this review posts. Not a coverage gap.
Follow-ups (non-blocking)
- Once #20 merges, future smoke tests can branch off
maindirectly so the diff isn't noisy. PR description already calls this out.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`CONTRIBUTING.md` listed only "refactors, docs, or test-only" as exempt from needing a changeset; `.changeset/README.md` also exempts `chore:` / `ci:` commits. One-line alignment.
Why this PR exists
Smoke test for #20 — the Argus AI review workflow. The PR is intentionally tiny and benign so we can verify the end-to-end pipeline (prompt build → Argus LLM run → `gh pr review` post → verifier confirm) on a docs-only change before exercising any MUST-FIX gates.
This PR is branched off #20 so the workflow file exists in the PR head — `pull_request` workflows fire from the merge of base + PR, and `ai-review.yml` isn't on `main` yet. Once #20 merges, future smoke tests can branch off `main` directly.
Expected outcome: Argus reviews this PR, classifies as docs-only (no `code-reviewer` delegation needed), and posts `--approve`.
Test plan
🤖 Generated with Claude Code