Skip to content

sales_catalog_driven test_kit sends feedback.satisfaction instead of performance_index #2626

@bokelley

Description

@bokelley

Problem

The `provide_performance_feedback` spec schema (`dist/schemas/3.0.0-rc.1/media-buy/provide-performance-feedback-request.json`) requires:

```json
"oneOf": [
{ "required": ["media_buy_id", "measurement_period", "performance_index"] },
{ "required": ["buyer_ref", "measurement_period", "performance_index"] }
]
```

The `sales_catalog_driven` storyboard sample_request correctly sends:
```yaml
performance_index: 1.4
metric_type: "conversion_rate"
feedback_source: "buyer_attribution"
```

But the SDK test_kit override at runtime sends:
```json
{
"media_buy_id": "...",
"measurement_period": {...},
"feedback": { "satisfaction": "positive", "notes": "E2E test feedback" }
}
```

`feedback`, `satisfaction`, and `notes` are NOT in the spec schema. A conformant implementer rejects with INVALID_REQUEST per the schema, and the storyboard grades them as failing.

Expected

Either:

  1. The test_kit should send the spec-declared fields (`performance_index`, `metric_type`, `feedback_source`) matching the storyboard's sample_request, OR
  2. The spec should add the `feedback` object shape if that's a desired alternative (and update the oneOf)

Impact

No conformant implementer can pass this step. Forces vendor-specific field handling.

Filed from training-agent 5.7 adoption storyboard audit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions