3.0.x: sales_guaranteed/create_media_buy fails with PRODUCT_NOT_FOUND after task_completion path fix

[bokelley]

Background

Surfaced after #3996 lands the storyboard fixture fix from #3990 onto 3.0.x.

Before the fix, the `create_media_buy` step in `sales_guaranteed/index.yaml` used `context_outputs[0].path: "media_buy_id"`, which resolved against the immediate A2A submitted-arm response — a step that fails earlier with `capture_path_not_resolvable`, masking everything downstream.

After the fix (`task_completion.media_buy_id`), the runner correctly polls `tasks/get` for the terminal artifact, the call actually executes against the test agent, and we hit the next bug: the test agent's product catalog doesn't carry `sports_preroll_q2_guaranteed` or `primetime_30s_mf`. Both storyboard dispatch modes fail identically:

```
× create_media_buy: PRODUCT_NOT_FOUND: Package 0: Product not found: sports_preroll_q2_guaranteed
× create_media_buy: PRODUCT_NOT_FOUND: Package 0: Product not found: primetime_30s_mf
```

On `main`, the equivalent storyboard run on PR #3990 passes — so the seeding works there. Something diverged between `main`'s and 3.0.x's training-agent fixture loading or the `controller_seeding` pathway.

What this issue tracks

Investigate why the `fixtures.products` block in `static/compliance/source/specialisms/sales-guaranteed/index.yaml` (which lists both `sports_preroll_q2_guaranteed` and the one referenced via `primetime_30s_mf` in `requires_scenarios`) doesn't reach the training agent's product catalog on 3.0.x storyboard runs. Likely candidates:

• 3.0.x's `server/src/training-agent/` fixture loader has drifted from the storyboard-schema's `fixtures.products` shape `main` uses.
• The `controller_seeding: true` pathway in the test-kit changed between branches.
• The test-kit `test-kits/acme-outdoor.yaml` has different product wiring on 3.0.x.

Once seeding works, `sales_guaranteed` should pass on 3.0.x's storyboard CI the same way it does on `main`.

Refs

• 3.0.6 cherry-picks: governance wire-placement + ctx_metadata reservation + storyboard fixture fixes #3996 — 3.0.6 cherry-pick that exposed this gap (lands the fixture fix; storyboard remains red on this scenario)
• fix(compliance): sales_guaranteed/create_media_buy — use task_completion.media_buy_id context_outputs path #3990 — `main`-side fix where the same fixture change passes (different seeding state on `main`)
• fix(storyboards): seed per-package products for multi-package create_media_buy #2894 — prior precedent for fixing per-package product seeding gaps

Note on 3.0.x storyboard CI baseline

This is one of 11 storyboards currently failing on 3.0.x's storyboard CI. PR #3893 was admin-merged with the same 11-fail baseline two days ago, so the failures predate this issue — `sales_guaranteed` is the one whose failure mode #3996 changes (capture-path → product-not-found). The other 10 are pre-existing baseline drift on 3.0.x and merit a separate sweep / threshold ratchet.

🤖 Generated with Claude Code

[bokelley]

Triage Report

Classification: Bug — compliance storyboard CI failure (3.0.x maintenance line)
Bucket: Execute (well-specified, non-breaking, in current patch window)
Status: Draft PR opened → #4008

---

Root Cause

The @adcp/client@5.21.1 storyboard runner used on 3.0.x does not implement the controller_seeding: true + fixtures.products product-seeding pathway introduced in @adcp/sdk v6.x. Before sales_guaranteed/create_media_buy and sales_broadcast_tv/create_media_buy are called, comply_test_controller.seed_product is never invoked, so session.complyExtensions.seededProducts stays empty. overlaySeededProducts() is a no-op, and productMap.get(pkg.product_id) returns undefined → PRODUCT_NOT_FOUND for all four fixture product IDs.

This failure was latent before PR #3996; the task_completion.media_buy_id path fix in #3996 caused the storyboard to advance past the previous failure point and surface the seeding gap.

Fix

Added sports_preroll_q2_guaranteed, outdoor_ctv_q2_guaranteed, primetime_30s_mf, and late_fringe_15s_mf as static catalog aliases in buildCatalog() (product-factory.ts), following the established v5.14 precedent for the same runner limitation. Source publisher for all four aliases is viewpoint_sports (the only publisher with deliveryTypes: ['guaranteed'] and both ctv + linear_tv channels).

Expert synthesis

Expert	Finding
code-reviewer (initial)	Root cause confirmed; fix approach matches historical precedent; implementation structurally correct
ad-tech-protocol-expert (initial)	Non-breaking additive change; patch-only; no RFC required
code-reviewer (pre-PR)	Publisher-finder predicates resolve correctly to viewpoint_sports; pricing-model inheritance from source is not validated by create_media_buy; not a blocker
ad-tech-protocol-expert (pre-PR)	No protocol surface change; catalog alias pattern consistent with spec

Notes

• Format ID mismatch (broadcast_spot_30s / broadcast_spot_15s in storyboard YAML vs broadcast_30s / broadcast_15s in FORMAT_CHANNEL_MAP) is a pre-existing nit — create_media_buy checks field_present not field_value for format in these tasks, so not a blocker for this fix. Logged separately.
• This is a 3.0.x-only workaround. The main branch is unaffected (runner seeds correctly via @adcp/sdk v6.x).

---

AdCP issue-triage agent · https://claude.ai/code/session_01C3siu1YwZuyBB3ootPAh4x

---

Generated by Claude Code

[bokelley]

Diagnostic notes from initial investigation

Regression boundary

`sales_guaranteed` last passed on 3.0.x storyboard CI on run 25071992367 (2026-04-28, head `d6002b1`). First failure on run 25144049186 (head `9dcf7aa`).

The bisect window is exactly one commit: `9dcf7aace1 — chore(3.0.x): re-cherry-pick #3461 and #3462 (envelope_field_present + asset-union) (#3608)`.

What `9dcf7aa` changed (suspect surfaces)

• `static/schemas/source/core/creative-asset.json` — refactored to use `asset-union.json` (–17 lines)
• `static/schemas/source/core/creative-manifest.json` — same refactor (–17 lines)
• `static/schemas/source/creative/list-creatives-response.json` — same refactor (–17 lines)
• New: `static/schemas/source/core/assets/asset-union.json`
• `static/compliance/source/universal/runner-output-contract.yaml` — minor edits
• `static/compliance/source/universal/storyboard-schema.yaml` — minor edits

The commit did NOT touch `server/src/training-agent/` — so the regression is indirect, likely via schema validation failing on a fixture step that previously passed.

Confirmed: same symptom, both dispatch modes

Both `Storyboards (framework dispatch)` and `Storyboards (legacy dispatch)` fail `sales_guaranteed` with identical `PRODUCT_NOT_FOUND` for `sports_preroll_q2_guaranteed`. The `sports_preroll_q2_guaranteed` product is in `sales-guaranteed/index.yaml`'s `fixtures.products` block; `controller_seeding: true` is set; sibling `sales_non_guaranteed` has identical YAML structure and passes on the same runs.

Most likely root cause

The runner reads `fixtures.products` and seeds them via `comply_test_controller.seed_product` calls keyed by session derived from `account.brand.domain`. Either:

1. Schema-validation gate fires before seeding. The asset-union refactor may have introduced a validation path that rejects `fixtures.products` entries with embedded `creative_assignments` (sales_guaranteed has `creative_assignments` in its `create_media_buy` step that reference `video_30s_trail_pro`). If the seeder validates the full step against the new schema and bails, products silently never reach the session.

2. Session-key drift between seed and create_media_buy calls. Same shape as the `v6 SalesPlatform shim brand threading` issue noted on `main` (PR feat(training-agent)!: migrate to @adcp/sdk@6.0.0 + split into per-specialism tenants #3713-era). On 3.0.x without v6 shims, the seed call and create_media_buy call may key into different sessions if the seed call happens before `account.brand.domain` is established.

3. Order-of-operations: `sales_guaranteed` uses `force_create_media_buy_arm` to force the SUBMITTED arm. The agent might evaluate product validation before the force-arm short-circuits, in a way `sales_non_guaranteed` (which doesn't force-arm) doesn't trip.

Path forward

Two options:

1. Backport the asset-union refactor's adopter side — find what main does to keep fixtures.products working post-refactor (likely a creative_assignments or product-shape adjustment in the agent's product registry) and bring that to 3.0.x.

2. Hardcode the fixture products into the training agent's default sales catalog on 3.0.x. Pragmatic; unblocks storyboard CI. Less elegant.

Filing this for picker; not a quick fix, and 11 of 52 storyboards are failing on 3.0.x baseline so this is one of several.

cc adcp-client#1487 (related enricher asymmetry on the same fixture surface).