Update format_id to structured object in docs#132
Merged
Conversation
Updated all documentation to match schema definition where format_id
is always a structured object with agent_url and id fields, not a
plain string.
Changes:
- Converted 114 occurrences across 17 documentation files
- format_id now consistently uses {"agent_url": "...", "id": "..."}
- Removes parsing ambiguity and namespace collision issues
- Aligns with /schemas/v1/core/format-id.json specification
Files updated:
- docs/creative/* (14 files)
- docs/media-buy/* (3 files)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Updated all 15 standard format schema files to reference the
structured format-id.json schema instead of using plain string
constants.
Before: "format_id": {"type": "string", "const": "display_300x250"}
After: "format_id": {"$ref": "/schemas/v1/core/format-id.json"}
This ensures standard formats properly validate against the
structured format ID object with agent_url and id fields.
Files updated:
- Display formats (7 files)
- Video formats (5 files)
- Native, foundational, and retail formats (3 files)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
EmmaLouise2018
approved these changes
Oct 17, 2025
bokelley
commented
Oct 17, 2025
docs/media-buy/capability-discovery/implementing-standard-formats.md
Outdated
Show resolved
Hide resolved
docs/media-buy/capability-discovery/implementing-standard-formats.md
Outdated
Show resolved
Hide resolved
The agent_url was appearing both inside format_id (correct) and as a top-level field in format objects (redundant). Since format_id is now a structured object containing agent_url, the separate field is unnecessary. Changes: - Removed agent_url from format.json schema - Removed 24 redundant agent_url occurrences from documentation examples - format objects now only have agent_url inside format_id Files updated: - static/schemas/v1/core/format.json - docs/media-buy/capability-discovery/implementing-standard-formats.md (11) - docs/media-buy/task-reference/list_creative_formats.md (9) - docs/creative/task-reference/list_creative_formats.md (4) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Mar 21, 2026
Two bugs prevented individual members (personal orgs with active subscriptions) from accessing Track B+ certification: 1. enrichUserWithMembership relied on primary_organization_id which was never set for users who joined after the initial migration backfill. Now falls back to organization_memberships with best-effort backfill. 2. getMemberContext/getWebMemberContext skipped resolveEffectiveMembership for personal orgs (is_personal=true), so Addie always saw individual members as non-members. Also extracts shared resolvePreferredOrganization/backfillPrimaryOrganization helpers to eliminate duplicated org-selection logic. Resolves escalations #132, #133, #134. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
bokelley
added a commit
that referenced
this pull request
Mar 21, 2026
Two bugs prevented individual members (personal orgs with active subscriptions) from accessing Track B+ certification: 1. enrichUserWithMembership relied on primary_organization_id which was never set for users who joined after the initial migration backfill. Now falls back to organization_memberships with best-effort backfill. 2. getMemberContext/getWebMemberContext skipped resolveEffectiveMembership for personal orgs (is_personal=true), so Addie always saw individual members as non-members. Also extracts shared resolvePreferredOrganization/backfillPrimaryOrganization helpers to eliminate duplicated org-selection logic. Resolves escalations #132, #133, #134. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The AdCP specification defines
format_idas a structured object containingagent_urlandid. However, many examples in the documentation incorrectly used simple string IDs. This inconsistency could lead to parsing errors and namespace confusion.Changes
This PR updates all occurrences of string-based
format_idin the documentation to the correct structured object format.format_idto an object.format_idto an object.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idto an object across multiple examples.format_idsto reflect the structured object.format_idto an object across multiple examples.Testing
format_idobject.