Closed
Conversation
The nav restructure in #1509 accidentally wrapped the 2.5 version's groups inside a "Documentation" group. This nesting pattern works for 3.0-rc but causes Mintlify to 404 on all 2.5.3 doc pages. Restores the flat groups array for the 2.5 version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The nav restructure in #1509 broke all 2.5.3 docs but no test caught it. The pre-push hook deletes dist/docs before running mintlify broken-links, and mintlify broken-links only checks cross-references, not nav structure. Adds tests/docs-nav-validation.test.cjs which validates: - All page references resolve to files on disk (including dist/docs/) - No empty groups in the navigation - Snapshot versions have consistent version prefixes - Snapshot versions use flat top-level groups (not a single wrapper) Wired into the test chain so it runs on every commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test caught that the "latest" version had the same Documentation wrapper bug as 2.5 — confirmed broken on the live site via vibium. Flatten the latest version's nav to use flat top-level groups. Improve docs-nav-validation.test.cjs per review feedback: - Check all non-default versions (not just dist/docs snapshots) - Detect wrapper groups by structural nesting, not page count - Add duplicate page reference detection - Add file extension detection in page paths - Remove dead collectGroups branch Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
Contributor
|
Closing in favor of #1505 - we need both fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/docs-nav-validation.test.cjs(15 tests) to prevent this class of bugWhat broke
PR #1509 wrapped all versions' nav groups inside a single "Documentation" group. This nesting pattern works for 3.0-rc (the default version) but causes Mintlify to 404 on non-default versions (latest and 2.5).
Why CI didn't catch it
rm -rf dist/docs) excludes versioned docs frommintlify broken-linksmintlify broken-linkschecks cross-references, not nav structure validityWhat the new test validates
Test plan
🤖 Generated with Claude Code