feat: Standardize webhook payload #168
Merged
youbek merged 8 commits intoadcontextprotocol:mainfrom Nov 3, 2025
Merged
Conversation
bokelley
reviewed
Oct 31, 2025
bokelley
reviewed
Nov 1, 2025
bokelley
approved these changes
Nov 1, 2025
5b0edde to
2428dea
Compare
bokelley
added a commit
that referenced
this pull request
Mar 31, 2026
Display endpoints (team members list and engagement dashboard) used membership_tier directly without inferring from subscription data when null. This caused orgs with null membership_tier but active subscriptions to see incorrect seat limits (e.g., 0 community seats instead of 5). Extracts resolveMembershipTier() helper to eliminate duplication across canAddSeat, members list, and engagement dashboard endpoints. Resolves escalation #168 (Propulso community seats showing 0). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
bokelley
added a commit
that referenced
this pull request
Mar 31, 2026
Display endpoints (team members list and engagement dashboard) used membership_tier directly without inferring from subscription data when null. This caused orgs with null membership_tier but active subscriptions to see incorrect seat limits (e.g., 0 community seats instead of 5). Extracts resolveMembershipTier() helper to eliminate duplication across canAddSeat, members list, and engagement dashboard endpoints. Resolves escalation #168 (Propulso community seats showing 0). Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task-specific fields are no longer merged at the top level in webhook POSTs. Webhooks now deliver a flat protocol envelope and place task data under result.
Motivation
adcp/clientbehavior, which already expects task data to be nested under a result field.What changed
static/schemas/v1/core/webhook-payload.jsonstatic/schemas/v1/index.jsondocs/protocols/task-management.mdxdocs/protocols/core-concepts.mdxdocs/protocols/envelope-examples.mdxdocs/media-buy/task-reference/create_media_buy.mdxdocs/media-buy/task-reference/update_media_buy.mdxdocs/media-buy/task-reference/sync_creatives.mdxBreaking changes
adcp/client, this change is not breaking (client already maps task data to result).Migration guide
New payload shape (canonical)
{ "operation_id": "op_123", "context_id": "ctx_abc", "task_id": "task_456", "task_type": "create_media_buy", "status": "completed", "message": "Media buy created successfully", "timestamp": "2025-01-22T10:30:00Z", "result": { "media_buy_id": "mb_12345", "buyer_ref": "nike_q1_campaign_2024", "packages": [{ "package_id": "pkg_001" }] }, "error": "optional string when status=failed" }Before vs After (compact)