fix: expose tagline field and harden XSS escaping in member directory#1680
Merged
Conversation
The tagline column exists in the database and is already indexed for search, but the profile editor UI was hardcoding tagline to null on every save. This adds a tagline input to the form, populates it on load, includes it in save data and card preview. Resolves Escalation #148 (Bryan Szekely / Sigma Software). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
XSS: tagline in members.html and description in member-card.js were rendered without escaping. Now that tagline is user-editable, both paths are reachable. Add server-side 200-char limit on tagline in POST and PUT. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
display_name, description, markets, offerings, and logo_url were rendered unescaped in both the card and detail views. Wrap all user-supplied values with escapeHtml/escapeHtmlSafe to prevent XSS. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Apply escapeHtml to contact_email, contact_phone, contact_website, linkedin_url, and twitter_url to prevent attribute injection in the member detail view. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bokelley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taglinefield in the organization member profile editor so companies can set a short headline that appears on directory cards and improves search ranking (resolves escalation Add tracker_script type to URL assets for measurement SDKs #148)Changes
Tagline field (member-profile.html):
XSS escaping (member-card.js, members.html):
display_name,description,tagline,markets,offeringswithescapeHtmlSafe()/escapeHtml()logo_urlanddisplay_namein imgsrc/altattributescontact_email,contact_phone,contact_website,linkedin_url,twitter_urlin detail viewServer-side (member-profiles.ts, already on main):
Escalation context
Test plan
🤖 Generated with Claude Code