Skip to content

fix: accept adcp_member.authoritative_location for brand.json verification#1758

Merged
bokelley merged 3 commits intomainfrom
bokelley/fix-brand-json-detect
Mar 31, 2026
Merged

fix: accept adcp_member.authoritative_location for brand.json verification#1758
bokelley merged 3 commits intomainfrom
bokelley/fix-brand-json-detect

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

Summary

  • Members publishing a full house_portfolio brand.json (instead of just an authoritative_location pointer) could not verify their domain — the verify endpoint only accepted the pointer variant
  • Now also checks adcp_member.authoritative_location for the AAO pointer URL
  • Improved UI messaging: distinguishes "no brand.json", "no hosted brand on AAO", and "pointer not verified" states
  • Added warning-level logging for invalid pointer URLs

Fixes Escalation #170 (Felipe Calvente / The Hook)

Test plan

  • TypeScript compiles clean
  • All pre-commit hooks pass (tests, schemas, typecheck, docs validation)
  • Unit tests pass (980/980)
  • Verify Felipe can click "Check now" and get verified after deploy
  • Verify existing authoritative_location pointer flow still works
  • Verify UI shows correct message for each failure state

🤖 Generated with Claude Code

bokelley and others added 3 commits March 31, 2026 15:29
…ation

Members who publish a full brand.json (house_portfolio variant) at their
domain instead of just the AAO pointer could not verify their domain.
The verify-brand endpoint now checks adcp_member.authoritative_location
in addition to the top-level authoritative_location field.

Also improves UI messaging to distinguish between no brand.json,
no hosted brand, and pointer mismatch states.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Defense-in-depth: verify the authoritative_location pointer uses https
before comparing hostname and pathname.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bokelley bokelley merged commit e70b691 into main Mar 31, 2026
12 checks passed
@bokelley bokelley deleted the bokelley/fix-brand-json-detect branch March 31, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant