feat(agents): triage runs pre-PR expert review on diff#2999
Merged
Conversation
Adds a mandatory pre-PR expert review step between "branch pushed" and `gh pr create`. Spawns code-reviewer + matching domain expert in parallel on `git diff main...HEAD`, classifies findings as blocker/nit/ out-of-scope, fixes blockers in up to 2 iterations, records sign-offs in PR body. Paired with flipping the triage routines from Opus 4.7 1M to Sonnet 4.6 so multi-step flows (draft, self-review, synthesize, PR) complete inside the idle-timeout window. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 24, 2026
Merged
bokelley
added a commit
to adcontextprotocol/adcp-client
that referenced
this pull request
Apr 24, 2026
Adds a mandatory pre-PR expert review step between "branch pushed" and `gh pr create`. Spawns code-reviewer + matching domain expert in parallel on `git diff main...HEAD`, classifies findings as blocker/nit/ out-of-scope, fixes blockers in up to 2 iterations, records sign-offs in PR body. Mirrors adcontextprotocol/adcp#2999. Paired with flipping triage routines from Opus 4.7 1M to Sonnet 4.6 so multi-step flows complete inside the idle-timeout window. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley
added a commit
to adcontextprotocol/adcp-client-python
that referenced
this pull request
Apr 24, 2026
Mirrors adcontextprotocol/adcp#2999. Adds mandatory pre-PR expert review on the diff (code-reviewer + domain expert in parallel) before `gh pr create`, capped at 2 review→fix iterations. Sign-offs recorded in PR body. Paired with flipping triage routines to Sonnet 4.6 so multi-step flows complete inside the idle-timeout window. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley
added a commit
to adcontextprotocol/adcp-go
that referenced
this pull request
Apr 24, 2026
Mirrors adcontextprotocol/adcp#2999. Adds mandatory pre-PR expert review on the diff (code-reviewer + domain expert in parallel) before `gh pr create`, capped at 2 review→fix iterations. Sign-offs recorded in PR body. Paired with flipping triage routines to Sonnet 4.6 so multi-step flows complete inside the idle-timeout window. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley
added a commit
to adcontextprotocol/adcp-client
that referenced
this pull request
Apr 24, 2026
… PR (#865) Adds a mandatory pre-PR expert review step between "branch pushed" and `gh pr create`. Spawns code-reviewer + matching domain expert in parallel on `git diff main...HEAD`, classifies findings as blocker/nit/ out-of-scope, fixes blockers in up to 2 iterations, records sign-offs in PR body. Mirrors adcontextprotocol/adcp#2999. Paired with flipping triage routines from Opus 4.7 1M to Sonnet 4.6 so multi-step flows complete inside the idle-timeout window. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley
added a commit
to adcontextprotocol/adcp-client-python
that referenced
this pull request
Apr 24, 2026
… PR (#269) Mirrors adcontextprotocol/adcp#2999. Adds mandatory pre-PR expert review on the diff (code-reviewer + domain expert in parallel) before `gh pr create`, capped at 2 review→fix iterations. Sign-offs recorded in PR body. Paired with flipping triage routines to Sonnet 4.6 so multi-step flows complete inside the idle-timeout window. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley
added a commit
to adcontextprotocol/adcp-go
that referenced
this pull request
Apr 24, 2026
… PR (#86) Mirrors adcontextprotocol/adcp#2999. Adds mandatory pre-PR expert review on the diff (code-reviewer + domain expert in parallel) before `gh pr create`, capped at 2 review→fix iterations. Sign-offs recorded in PR body. Paired with flipping triage routines to Sonnet 4.6 so multi-step flows complete inside the idle-timeout window. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Triage routine now runs a mandatory pre-PR expert review on the actual diff (not just the plan) before opening the PR. Spawns
code-reviewer+ the matching domain expert in parallel, classifies findings as blocker/nit/out-of-scope, fixes blockers in up to 2 iterations, records sign-offs in the PR body.Paired with flipping all 5 routines (4 triage + 1 context-refresh) from
claude-opus-4-7[1m]→claude-sonnet-4-6. The stream-idle timeouts we've been hitting on multi-step sessions (issues #2987, python#263) suggest the orchestrator was the bottleneck; Sonnet is 3-5x faster per step and the deep thinking stays in Opus-backed Task subagents.Changes
.agents/routines/triage-prompt.md— new## Pre-PR expert reviewsection between "Bundling" and "PR constraints"Sibling PRs to follow on adcp-client, adcp-client-python, adcp-go.
Test plan
🤖 Generated with Claude Code