chore(deps): bump @adcp/client 5.15 → 5.16 + restore fresh replayed assertion#3034
Merged
chore(deps): bump @adcp/client 5.15 → 5.16 + restore fresh replayed assertion#3034
Conversation
…ssertion 5.16.0 ships the two follow-ups from the 5.15 bump: - field_value_or_absent matcher (adcp-client#873). Passes when field is absent OR present with a matching value. The envelope-spec escape hatch we needed for fresh-path `replayed`. - context_value_rejected hints (adcp-client#870). Non-fatal runner hints when a seller error's `available:` list would have accepted a prior-step `$context.*` value. Uses the new matcher to restore positive coverage on the `universal/idempotency.yaml::create_media_buy_initial::replayed` assertion: "if reported on fresh execution, must be false". The replay step's positive assertion is unchanged. Both dispatch modes remain 52/52 clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 24, 2026
This was referenced Apr 24, 2026
bokelley
added a commit
that referenced
this pull request
Apr 24, 2026
…layed assertion (#3074) Follow-up to #3032 (documented the check) and #3034 (restored the initial-step replayed assertion). Two small gaps remained, surfaced while triaging superseded PR #3037: 1. scripts/lint-storyboard-contradictions.cjs — hasPositiveAssertion listed the older check kinds but not field_value_or_absent. Any storyboard using it as the only positive assertion was misclassified as "unspecified." Now classified correctly as "success." 2. static/compliance/source/universal/idempotency.yaml — the create_media_buy_fresh_key step is a non-replay call, so the same replayed tolerance #3034 restored on create_media_buy_initial applies: replayed MAY be omitted, but if present MUST NOT be true. Added the symmetric field_value_or_absent [false] assertion so fresh-key coverage matches initial-call coverage. Both additions are purely additive. Agents that omit replayed on fresh execution pass (spec-correct). Only agents setting replayed: true on a fresh call fail — already a spec violation per PR #3013. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@adcp/clientfrom5.15.0to5.16.0field_value_or_absentmatcher to restore positive coverage on the fresh-pathreplayedassertion inuniversal/idempotency.yaml::create_media_buy_initial5.16.0 ships the two follow-ups from our last bump
field_value_or_absentmatcher (adcp-client#873, filed from this repo). Passes when a field is absent OR present with a matching value; fails only when present with a disallowed value. The envelope-spec escape hatch we needed forreplayedon fresh execution.context_value_rejectedhints when a seller's error response'savailable:list would have accepted a value that traces back to a prior-step$context.*write. Pass/fail unchanged; hints surface onStoryboardStepResult.hints[].Both upstream issues were closed by the 5.16 merge.
Spec-side change
In
universal/idempotency.yaml'screate_media_buy_initialstep, replaced the comment block explaining the absent assertion with an actualfield_value_or_absentassertion:The replay step's
field_value: allowed_values: [true]onreplayedis unchanged.Test plan
🤖 Generated with Claude Code