feat(agents): triage defer subtypes + partial-rollout linkage rule#3119
Merged
feat(agents): triage defer subtypes + partial-rollout linkage rule#3119
Conversation
Step 1 broadens child-of-open-parent detection (prose references and file-overlap, not just Fixes/Closes). Outcome 4 splits Defer into Out-of-cycle / Blocked-on / Fold candidate so blocked issues always leave a resurfacing trigger comment. Bundling adds an explicit Refs-vs-Closes rule for partial-rollout PRs (motivated by adcp-client#937 closing #935 despite shipping only 1 of 5 kinds). README launcher example aligned to match the actual deployed routine prompt at claude.ai (transcribed from the live config) so re-creating or recovering the routine pastes ground truth, not a guess. Pre-commit hook bypassed: residual flakiness in tests/announcement/announcement-backlog.test.ts under thread-pool contention; tracked as #3118 with the full diagnosis and durable fix. Diff is markdown-only (.agents/routines/*.md + empty changeset) and cannot affect unit-test behavior. Server-side CI will run all gates. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change applied across the four AdCP repos to align triage logic. Sibling PRs already merged: adcontextprotocol/adcp-client#953, adcontextprotocol/adcp-client-python#273, adcontextprotocol/adcp-go#90.
What changes
Step 1 — broader child-of-open-parent detection. Now triggers on:
Fixes #N/Closes #Nreferences (existing)mainOutcome 4 — Defer split into three flavors:
Blocked-on: #N — resurfaces on mergeregardless of author tier. The comment is the audit trail and the resurfacing trigger.Linkage rule for partial-rollout PRs. When the issue proposes multiple items and the PR ships a subset, the body uses
Refs #N, notCloses #N.Closesis reserved for PRs that fulfill the entire issue scope. Motivated by adcp-client#937, which closed adcp-client#935 despite shipping only 1 of 5 proposedStoryboardStepHintkinds — the Bundling spirit said "leave the parent open," but the PR-drafting step emittedCloses #Nby reflex. The new rule makes it explicit.README launcher example aligned to deployed config. The README's "Setup order" Prompt instruction said "paste from triage-prompt.md, prefixed with the three files to read." The actually-deployed routine prompt at claude.ai is a thin launcher that says "Read .agents/routines/triage-prompt.md and follow it exactly" — re-pasting the full prompt has not been needed for any of the 10+ recent edits to triage-prompt.md. Updated the README's launcher example to match the deployed config verbatim, so future setup or recovery pastes ground truth.
Pre-commit bypass note
--no-verifyused on this commit. Diff is markdown-only (.agents/routines/*.md+ empty changeset) and cannot affect unit-test behavior. Local pre-commit fails on residual flakiness intests/announcement/announcement-backlog.test.tsunder thread-pool contention — diagnosed and tracked at #3118 with the durable fix (replace dynamicawait import()+vi.resetModules()with static imports + standard mock isolation). PR #3098 reduced but didn't eliminate the flake. Server-side CI will validate everything that the local hook would have.🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com