Conversation
…sion_tracker in creatives.mdx The impression_tracker URL asset example at line 213 used `"url_type": "tracking_pixel"` inside a requirements block — wrong on two counts: `url_type` is not a property of `url-asset-requirements.json` (it lives on the manifest-side asset payload), and `tracking_pixel` is not a valid `url-asset-type.json` enum value. The correct constraint for this URL slot is `"role": "impression_tracker"` per the `url-asset-requirements` schema. Closes #3692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3692
The asset discovery example at
docs/reference/migration/creatives.mdx:213used"url_type": "tracking_pixel"inside arequirementsblock — wrong on two counts:url_typeis not a property ofurl-asset-requirements.json(it lives on the manifest-side asset payload inurl-asset.json), andtracking_pixelis not a validurl-asset-type.jsonenum value (valid:clickthrough/tracker_pixel/tracker_script). The correct constraint for this URL slot in a format definition is"role": "impression_tracker", using theroleenum fromurl-asset-requirements.json. This goes in the same direction as #3670 / #3671 / #3673 — aligning migration docs with actual schema shapes so sellers following the docs produce conformant output.Non-breaking justification: docs-only change; no schema or wire format was modified.
url-asset-requirements.jsonalready hasadditionalProperties: true, so the old example validated silently but with no enforced semantic. The fix corrects the teaching example to use the schema-correct field.Note on
dist/docs/occurrences:grepfinds five matching strings indist/docs/3.0.{0,1,2}/anddist/docs/3.0.0-rc.{1,2}/. These are immutable versioned snapshots generated byrelease-docs.ymlon each publish and are intentionally left unchanged — they are the historical record of what shipped, not source files.Pre-PR review:
"role": "impression_tracker"is the correct field and value perurl-asset-requirements.json; blocker from first pass (wrong field) resolved in second pass; no remaining blockerstracker_pixelenum value confirmed correct;--emptychangeset correct for docs-only;dist/docs/occurrences are release snapshots, intentionally out of scopeSession: https://claude.ai/code/session_01XUwgQ1QoFMErF3k5A65AeJ
Generated by Claude Code