Conversation
Surface seeded creative_policy fields in get_products, enforce provenance_requirements / accepted_verifiers on sync_creatives, remove creative_sales_agent/provenance_enforcement from KNOWN_FAILING_STORYBOARDS. https://claude.ai/code/session_013AgZkVzoaN9YBEJp3FeBk8
…red; accurate field paths Per spec MUST-ignore rule: only extract provenance_requirements when provenance_required === true. Fix verify_agent field path to name the correct sub-array (embedded_provenance vs watermarks) on rejection. https://claude.ai/code/session_013AgZkVzoaN9YBEJp3FeBk8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3777
Implements
creative_policy.{provenance_required, provenance_requirements, accepted_verifiers}enforcement in the training agent so thecreative_sales_agent/provenance_enforcementconformance storyboard passes (was failing 3 of 5 step validations).Changes
handleGetProducts(task-handlers.ts)Seeded products (from
comply_test_controller seed_product) are now included inget_productsresponses viaoverlaySeededProducts. Previously only the static catalog was used. Seeded products that score zero on brief-mode keyword matching (they have noname/descriptionby default) are prepended to the result so storyboardfield_valuechecks onproducts[0].creative_policy.*pass.handleSyncCreatives(task-handlers.ts)Structural provenance enforcement derived from all seeded products'
creative_policy. Checks run in spec order before persisting each creative:PROVENANCE_VERIFIER_NOT_ACCEPTED) — fires first per spec "cross-check before any outbound call" requirement; compares canonicalizedverify_agent.agent_urlagainst the accepted setPROVENANCE_REQUIRED) — fires whenprovenance_required: trueand no provenance objectPROVENANCE_DIGITAL_SOURCE_TYPE_MISSING,PROVENANCE_DISCLOSURE_MISSING,PROVENANCE_EMBEDDED_MISSING) — gated onprovenance_required: trueper spec MUST-ignore rule forprovenance_requirementswhenprovenance_requiredis false/absent; short-circuits at first failurePer-creative failures use
action: 'failed'witherrors[](already in thesync-creatives-response.jsonschema enum; not persisted to session).SyncCreativeResulttype widened to include'failed'and optionalerrors.run-storyboards.tsRemoves
creative_sales_agent/provenance_enforcementfromKNOWN_FAILING_STORYBOARDS.Non-breaking justification
Adds enforcement only when seeded products have
provenance_required: trueincreative_policy. Static catalog products have no such field. Sessions without seeded products are unaffected —hasProvenancePolicyis false and the enforcement block is a no-op. Theaction: 'failed'path was already defined in the schema.Known simplification
sync_creativeshas noproduct_idfield, so per-product enforcement is not possible.acceptedVerifiersuses union semantics across all seeded products — documented in a code comment. In single-product storyboards (the typical case) union === intersection.Out of scope / follow-up needed
.github/workflows/training-agent-storyboards.ymlthresholds (min_clean_storyboards,min_passing_steps) need a human bump after this merges — the routine cannot edit.github/**. The storyboard adds 4 steps (1 new clean storyboard).PROVENANCE_CLAIM_CONTRADICTED(truth-of-claim viaget_creative_featuresagainst an on-list governance agent) is out of scope per the issue; the structural-rejection codes are sufficient to make the storyboard pass.Pre-PR review
provenance_requirementsMUST-ignore rule fixed before this PR opened; accuratefieldpath for watermarks vs embedded_provenance fixed before this PR opened)Session: https://claude.ai/code/session_013AgZkVzoaN9YBEJp3FeBk8
Generated by Claude Code