docs(security): cosign verify-blob trust model + cert-subject lookup#3793
Merged
docs(security): cosign verify-blob trust model + cert-subject lookup#3793
Conversation
Adds docs/reference/verifying-protocol-tarballs.mdx covering the keyless Sigstore trust model for AdCP protocol bundles, the recommended verify-blob invocation, and a per-release cert-subject table so consumers know what to expect. Updates docs/building/schemas-and-sdks.mdx to use the canonical refs/(heads|tags)/.* regex (was refs/heads/.*) and link to the new doc. The new doc explains why a wildcard branch component is correct: the release.yml workflow's own on.push.branches allowlist is what gates which refs can produce a signature, so mirroring that list in every consumer's regex was a maintenance liability that silently broke v3.0.1+ verification when the 3.0.x maintenance branch was cut. Companion SDK fixes: adcontextprotocol/adcp-client#1243 (TS), adcontextprotocol/adcp-client-python#343 (Python). adcp-go was already on the canonical pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `docs/reference/verifying-protocol-tarballs.mdx` — a dedicated reference for verifying AdCP protocol bundle signatures with cosign keyless. Updates `docs/building/schemas-and-sdks.mdx` to use the canonical regex and link to the new doc.
Why
Adopters running `@adcp/sdk sync-schemas` against v3.0.1+ saw cryptic verification failures ("none of the expected identities matched") because the cert subject for those releases is `release.yml@refs/heads/3.0.x` — not `refs/heads/main` like v3.0.0. The SDK's regex was a literal allowlist that didn't include `3.0.x`. The fix on the consumer side is straightforward (broaden the regex), but until now the "why" wasn't documented anywhere — every consumer who hit the failure had to reason through it from scratch.
This doc:
Companion SDK fixes
Files
Test plan
🤖 Generated with Claude Code