fix(training-agent): wire seed.creative_format on /sales tenant#4066
Merged
fix(training-agent): wire seed.creative_format on /sales tenant#4066
Conversation
/sales advertises list_creative_formats so the universal pagination_integrity_creative_formats storyboard fires there too. The seed.creative_format slot was missing from buildSalesComplyConfig, so the SDK dispatcher returned UNKNOWN_SCENARIO before the v5 handler's LOCAL_SCENARIOS path could service the seed. Add the adapter to mirror what /creative and /creative-builder already wire. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pagination_integrity_creative_formatsis a universal storyboard gated onlist_creative_formats. The tool catalog advertiseslist_creative_formatsonsales,creative, andcreative-builder(the SDK auto-registers it whenever a tenant claims a creative archetype), butbuildSalesComplyConfigonly registered the seed adapters relevant to the sales-track storyboards (product,pricing_option,media_buy,creative). Thecreative_formatslot was missing.Result:
seed_creative_formatcalls on/sales/mcphit the SDK dispatcher'sif (!store.seedCreativeFormat) return UNKNOWN_SCENARIObranch and returnedsuccess: falsebefore the v5 handler's LOCAL_SCENARIOS pre-handler could service them. Theseed_format_1storyboard step graded "Expected true, got false" and downstream pagination steps skipped.Floor lift on /sales:
Other tenants flat —
/creativeand/creative-builderalready wire the adapter viabuildCreativeComplyConfig, and the rest don't claimlist_creative_formats.Test plan
pagination_integrity_creative_formatsstoryboard now passes 5P/0F on /sales🤖 Generated with Claude Code