Skip to content

fix(training-agent): wire seed.creative_format on /sales tenant#4066

Merged
bokelley merged 1 commit intomainfrom
bokelley/sales-seed-creative-format
May 4, 2026
Merged

fix(training-agent): wire seed.creative_format on /sales tenant#4066
bokelley merged 1 commit intomainfrom
bokelley/sales-seed-creative-format

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

@bokelley bokelley commented May 4, 2026

Summary

pagination_integrity_creative_formats is a universal storyboard gated on list_creative_formats. The tool catalog advertises list_creative_formats on sales, creative, and creative-builder (the SDK auto-registers it whenever a tenant claims a creative archetype), but buildSalesComplyConfig only registered the seed adapters relevant to the sales-track storyboards (product, pricing_option, media_buy, creative). The creative_format slot was missing.

Result: seed_creative_format calls on /sales/mcp hit the SDK dispatcher's if (!store.seedCreativeFormat) return UNKNOWN_SCENARIO branch and returned success: false before the v5 handler's LOCAL_SCENARIOS pre-handler could service them. The seed_format_1 storyboard step graded "Expected true, got false" and downstream pagination steps skipped.

seed: {
  ...
  creative_format: cast(seedAdapter('seed_creative_format')),
},

Floor lift on /sales:

Tenant Old (post-#4061) New Delta
/sales 64 / 248 65 / 252 +1 / +4

Other tenants flat — /creative and /creative-builder already wire the adapter via buildCreativeComplyConfig, and the rest don't claim list_creative_formats.

Test plan

  • Local matrix run — all six tenants pass new floors
  • CI matrix run on PR
  • pagination_integrity_creative_formats storyboard now passes 5P/0F on /sales

🤖 Generated with Claude Code

/sales advertises list_creative_formats so the universal
pagination_integrity_creative_formats storyboard fires there too. The
seed.creative_format slot was missing from buildSalesComplyConfig, so
the SDK dispatcher returned UNKNOWN_SCENARIO before the v5 handler's
LOCAL_SCENARIOS path could service the seed. Add the adapter to mirror
what /creative and /creative-builder already wire.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@bokelley bokelley merged commit 59bba55 into main May 4, 2026
19 checks passed
@bokelley bokelley deleted the bokelley/sales-seed-creative-format branch May 4, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant