Skip to content

chore(deps): bump @adcp/sdk to ^6.19.0; drop vector-028 skipVectors workaround#4359

Merged
bokelley merged 1 commit into
mainfrom
bokelley/sdk-6.19-drop-vector-028-skip
May 11, 2026
Merged

chore(deps): bump @adcp/sdk to ^6.19.0; drop vector-028 skipVectors workaround#4359
bokelley merged 1 commit into
mainfrom
bokelley/sdk-6.19-drop-vector-028-skip

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

Summary

Closes the loop on the vector-028 / proposal-mode chain. @adcp/sdk@6.19.0 now ships both pieces the test-agent needs:

  • 6.18.0 (adcp-client#1644): adversarial builder for conformance vector 028-unsigned-protocol-method-required (the unsigned tasks/cancel JSON-RPC POST that grades protocol_methods_required_for, introduced in adcp#4326).
  • 6.19.0 (adcp-client#1649): proposal-mode enricher fix — fixture's explicit packages wins over auto-captured context.proposal_id, so storyboards that intentionally exercise package-mode don't get forced through proposal-lifecycle validation.

This PR:

  1. Bumps @adcp/sdk to ^6.19.0.
  2. Drops the 028-unsigned-protocol-method-required line from server/tests/manual/run-storyboards.ts::skipVectors so the runner actually exercises vector 028.

Test plan

  • bash scripts/run-storyboards-matrix.sh — all 6 tenants meet floors. Per-tenant step counts lift by +1 (vector 028 grading):
    Tenant Before After
    /signals 58 59
    /sales 258 260
    /governance 102 103
    /creative 118 119
    /creative-builder 100 101
    /brand 45 46
  • tsc --project server/tsconfig.json --noEmit (clean, ran via pre-commit hook)

🤖 Generated with Claude Code

…orkaround

6.18.0 added the adversarial builder for conformance vector 028
(adcp-client#1644). 6.19.0 ships the proposal-mode enricher fix
(adcp-client#1649) that PR #1603's over-application surfaced —
required to keep the storyboard matrix green at SDK 6.18+.

Drops `028-unsigned-protocol-method-required` from skipVectors so
the runner actually exercises vector 028 (the unsigned tasks/cancel
JSON-RPC POST that grades `protocol_methods_required_for`).

Matrix lift: +1 step per tenant from vector 028 grading.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@bokelley bokelley merged commit 7aeca49 into main May 11, 2026
20 checks passed
@bokelley bokelley deleted the bokelley/sdk-6.19-drop-vector-028-skip branch May 11, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant