fix(dashboard): drop unfiltered /api/storyboards fallback (closes #4254)#4369
Merged
Merged
Conversation
When /api/registry/agents/:url/applicable-storyboards returned a generic error — capabilities probe failure for any reason other than the recognized OAuth / needs-auth / unknown-specialism shapes — the dashboard fell back to /api/storyboards (the FULL unfiltered storyboard catalog). So a signals-only agent rendered pagination-creative-formats, get-media-buys-pagination-integrity, collection-lists-pagination- integrity, and the rest, even though none of those are applicable. That's misleading: without the agent's declared protocols + specialisms, we have no basis for showing any storyboard list. The applicable- storyboards endpoint's own filter (via resolveStoryboardsForCapabilities) is the only correct surface; falling back to the unfiltered catalog defeats it. Fix: remove the fallback. Keep the error message, suffix it with a pointer to the underlying contract (get_adcp_capabilities must return supported_protocols + specialisms before applicable storyboards can be computed). OAuth / needs-auth / unknown-specialism error paths unchanged — those still surface their respective actionable UIs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4254. The dashboard's storyboard picker was falling back to the unfiltered full catalog when
applicable-storyboardsreturned a generic error, defeating the per-agent filter.The bug
The dashboard renders the storyboard picker by calling
/api/registry/agents/:url/applicable-storyboards, which usesresolveStoryboardsForCapabilitiesto filter to (universal baseline + protocol baseline + declared specialisms). That endpoint works correctly.But when it returned anything other than 2xx / OAuth-challenge / needs-auth / unknown-specialism (e.g. capabilities probe failed for a different reason), the dashboard fell back to
/api/storyboards— the unfiltered, registry-wide catalog. So a signals-only agent rendered pagination-creative-formats, get-media-buys-pagination-integrity, collection-lists-pagination-integrity, and the rest. The issue report's "20+ storyboards including pagination-integrity (list_creatives)" is exactly this code path firing.Fix
Drop the fallback. Keep the error message; suffix it with the underlying contract pointer (
get_adcp_capabilitiesmust returnsupported_protocolsandspecialismsbefore applicable storyboards can be computed). OAuth, needs-auth, and unknown-specialism error paths unchanged — those still surface their respective actionable UIs (authorize button / connect form / specialism list).Test plan
Stack note
Part of Push A in the compliance reporting fidelity initiative (PR #4364 → this PR → docs-disambiguation PR → canonical-surface UI). Orthogonal to Emma's #4247 unification stack.
🤖 Generated with Claude Code