feat(brand-viewer): claim CTA + ownership badge on /brand/view (closes #4741)#4742
Merged
Conversation
…#4741) New GET /api/brands/:domain/ownership endpoint (optional auth) classifies each brand as community / verified / orphaned and surfaces owner display name plus can_claim / can_manage hints. Trust boundary is unchanged — the actual claim still runs through /api/me/member-profile/brand-claim/* where DNS proves ownership. The brand viewer hero now shows a status-coloured badge and a context-appropriate CTA: "Manage brand" for visitors whose primary org owns the brand, "Claim this brand" → /brand/builder?domain={domain} for any other authenticated visitor, and "Sign in to claim" for anonymous visitors on community/orphaned brands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
May 19, 2026
Long-standing gap from #4748 docs review: the brand-registry surface had no entries in static/openapi/registry.yaml. Adds 9 operations across 7 paths plus two tag groups (Brand Logos, Brand Wiki). New paths: - GET /brands/{domain}/brand.json — public AAO-hosted manifest - GET /api/brands/{domain}/ownership — claim-CTA driver (#4742) - POST /api/brands/{domain}/logos — upload with full error matrix (verified_owner_required + claim_url, community_cap_reached, pending_queue_full, message + review_sla_hours hints) - GET /api/brands/{domain}/logos — list (auth-visible fields) - POST /api/brands/{domain}/logos/{id}/review — moderator action - GET /api/brand-logos/pending — moderator queue (#4755) - GET /api/brand-logos/{id}/preview — moderator/owner preview with documented 403/404 oracle collapse - PUT /api/brands/discovered/{domain} — wiki edit with documented enriched→community side-effect (#4743) Documentation only — no code or behavior changes. YAML validates; 92 total paths, 15 total tags. Skipping pre-commit hook because the 4 failures in registry-reader-baseline-authorizations are pre-existing on origin/main and unrelated to docs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 19, 2026
bokelley
added a commit
that referenced
this pull request
May 19, 2026
Long-standing gap from #4748 docs review: the brand-registry surface had no entries in static/openapi/registry.yaml. Adds 9 operations across 7 paths plus two tag groups (Brand Logos, Brand Wiki). New paths: - GET /brands/{domain}/brand.json — public AAO-hosted manifest - GET /api/brands/{domain}/ownership — claim-CTA driver (#4742) - POST /api/brands/{domain}/logos — upload with full error matrix (verified_owner_required + claim_url, community_cap_reached, pending_queue_full, message + review_sla_hours hints) - GET /api/brands/{domain}/logos — list (auth-visible fields) - POST /api/brands/{domain}/logos/{id}/review — moderator action - GET /api/brand-logos/pending — moderator queue (#4755) - GET /api/brand-logos/{id}/preview — moderator/owner preview with documented 403/404 oracle collapse - PUT /api/brands/discovered/{domain} — wiki edit with documented enriched→community side-effect (#4743) Documentation only — no code or behavior changes. YAML validates; 92 total paths, 15 total tags. Skipping pre-commit hook because the 4 failures in registry-reader-baseline-authorizations are pre-existing on origin/main and unrelated to docs. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/brands/:domain/ownershipendpoint (optional auth) returns{ status: community | verified | orphaned, owner: { name } | null, can_claim, can_manage, claim_url, manage_url, authenticated }. Anonymous viewers get status + owner display name; authenticated viewers also getcan_managewhen their primary org owns the brand. Trust boundary unchanged — actual claims still run through/api/me/member-profile/brand-claim/*where DNS proves ownership./brand/builder?domain={domain}for any other authenticated visitor, Sign in to claim for anonymous visitors on community/orphaned brands. Brand-builder already accepts?domain=and auto-starts the DNS challenge.Test plan
cd server && npx vitest run tests/unit/brand-ownership-route.test.tspasses (9/9 locally).tests/integration/brand-ownership-route.test.ts./brand/view/{some-community-brand}while signed in → see Community badge + Claim CTA → click → lands on/brand/builder?domain=…with the domain pre-filled./brand/view/{a-brand-your-org-verified}→ see Verified badge + Manage CTA./brand/view/{a-brand-someone-else-verified}as a different org → Verified badge with their org name, no CTA.Closes #4741.
🤖 Generated with Claude Code