deps: bump @types/node from 22.19.19 to 24.12.4#5002
Merged
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.19 to 24.12.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 24.12.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![aao-release-bot[bot]](https://avatars.githubusercontent.com/u/221690821?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM. Follow-ups noted below. TypeScript build is the gate here — devDeps-only change, no wire surface.
Things I checked
- Diff is three files:
.changeset/types-node-24.md(new, 5 lines),package.json(1/1),package-lock.json(8/8). No source, schema, or docs touched. @types/nodeis a devDependency. Bump does not affect the published wire shape or anything downstream agents see.- Changeset is
patch— correct.@types/nodeis not a runtime dep ofadcontextprotocolconsumers, so this is not minor/major-worthy on the package's own semver. - Transitive
undici-typesfollows along (~6.21.0→~7.16.0) — expected for the major bump. engines.nodestays at>=22.22.0(package.json:engines).
Follow-ups (non-blocking — file as issues)
@types/nodefloor now exceedsengines.nodefloor.@types/node@^24.12.4exposes type defs for APIs added in Node 23/24, butengines.nodeis>=22.22.0. TS will silently accept calls to APIs that won't exist on the minimum supported runtime. Either raiseengines.nodeto>=24(if Node 22 support is being dropped — needs its own decision and amajorchangeset on anything publishable) or pin@types/nodeback to^22until the engines floor moves. The standard pattern is to keep@types/nodemajor aligned with the lowest supported Node major.- Worth adding a Dependabot ignore rule for
@types/nodemajors above the engines floor so this conversation doesn't reopen every release cycle.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @types/node from 22.19.19 to 24.12.4.
Commits
Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)