feat: add click_tracker asset to clickable formats #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added create_click_tracker_asset() helper function for 3rd party click tracking redirect URLs. Added click_tracker to 9 clickable formats: - display_image (responsive) - display_300x250_image - display_728x90_image - display_320x50_image - display_160x600_image - display_336x280_image - display_300x600_image - display_970x250_image - native_content Click tracker is optional (required=False) and uses url_type='tracker_redirect' to distinguish from impression trackers.
Contributor
|
I think you can add click trackers to JS and HTML, as well as to vast |
- Test click_tracker asset properties (id, type, required, url_type) - Test click_tracker is only on clickable formats (9 total) - Test click_tracker is NOT on audio/video/dooh formats
Added click_tracker to 10 additional formats: - display_html (+ 7 sized variants) - display_js - video_vast - video_vast_30s Total formats with click_tracker: 19 Updated tests to reflect new coverage.
Fixes RUF012 linter warning about mutable class attributes.
Collaborator
Author
|
Local test |
Added click_tracker to 8 generative formats: - display_generative (+ 7 sized variants) Total formats with click_tracker: 27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
click_trackerasset support for 3rd party click tracking across display, generative, HTML, JS, VAST, and native ad formats.Changes
New Helper Function
Added
create_click_tracker_asset()that creates an optional URL asset with:asset_id:click_trackerurl_type:tracker_redirect(distinguishes from impression trackers which usetracker_pixel)required:False(optional for all formats)Updated Formats (27 total)
display_generative,display_300x250_generative,display_728x90_generative,display_320x50_generative,display_160x600_generative,display_336x280_generative,display_300x600_generative,display_970x250_generativedisplay_image,display_300x250_image,display_728x90_image,display_320x50_image,display_160x600_image,display_336x280_image,display_300x600_image,display_970x250_imagedisplay_html,display_300x250_html,display_728x90_html,display_160x600_html,display_336x280_html,display_300x600_html,display_970x250_htmldisplay_jsvideo_vast,video_vast_30snative_contentFormats NOT Updated
Usage
Advertisers can now provide a 3rd party click tracking URL:
{
"format_id": { "agent_url": "...", "id": "display_300x250_image" },
"input": {
"banner_image": { "url": "https://..." },
"click_url": { "url": "https://advertiser.com/landing" },
"impression_tracker": { "url": "https://tracker.com/impression" },
"click_tracker": { "url": "https://tracker.com/click?redirect=${CLICK_URL}" }
}
}