chunk of code was indented too far#3
Closed
trevnorris wants to merge 1 commit intoaddyosmani:masterfrom
trevnorris:spacingfix
Closed
chunk of code was indented too far#3trevnorris wants to merge 1 commit intoaddyosmani:masterfrom trevnorris:spacingfix
trevnorris wants to merge 1 commit intoaddyosmani:masterfrom
trevnorris:spacingfix
Conversation
Owner
|
I think we'll end up reformatting most of the code once the basic logic has been sorted out (with a set indendation/spacing standard) but for now, thanks!. I'll merge. |
Contributor
Author
|
ok, cool. I just didn't want to accidentally botch a future pull request because I didn't follow the indentation standard, but if you're not worried about it then I'm not. |
Collaborator
|
Addy, can't see that you actually merged this one. I can do it if you haven't gotten around to it yet. :) |
Owner
|
@peol Please feel free to, sir! :) This one requires a bit of a manual merge. |
Collaborator
|
Manually merged, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large chunk of code was indented 8 spaces instead of the 4 that was used throughout the rest of the source file.