Worked on todo for addListener and removeListener assignments#6
Merged
peol merged 1 commit intoaddyosmani:masterfrom Dec 26, 2011
benbabics:master
Merged
Worked on todo for addListener and removeListener assignments#6peol merged 1 commit intoaddyosmani:masterfrom benbabics:master
peol merged 1 commit intoaddyosmani:masterfrom
benbabics:master
Conversation
…sure methods aren't invoked multiple times.
Collaborator
|
Looks good, thanks! We'll probably continue working on this area but this is a good start. |
peol
added a commit
that referenced
this pull request
Dec 26, 2011
Worked on todo for addListener and removeListener assignments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encapsulated addListener and removeListener events in a closure to ensure methods aren't invoked multiple times. This is my first ever fork, so PLEASE be kind. lol :)