update sample to work with firefox (no auto instanciated id)#5
Merged
addyosmani merged 1 commit intoaddyosmani:gh-pagesfrom Jan 6, 2015
enguerran:firefox
Merged
update sample to work with firefox (no auto instanciated id)#5addyosmani merged 1 commit intoaddyosmani:gh-pagesfrom enguerran:firefox
addyosmani merged 1 commit intoaddyosmani:gh-pagesfrom
enguerran:firefox
Conversation
Owner
|
I'm all for improving overall x-browser compat, but wasn't aware FF wasn't able to handle this properly. I'll do some testing against master and your PR to verify this is the best fix we can opt for. Thanks again (and sorry for the delay reviewing!) |
Contributor
Author
|
No problem for the delay, give me some feedback when you can. We all know you can be a very busy man. |
addyosmani
added a commit
that referenced
this pull request
Jan 6, 2015
update sample to work with firefox (no auto instanciated id)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite the "spec", firefox cannot handle the id-to-global-variable in the demo.html.
I found some resources speaking about this spec I did not know:
What do you think?