Skip to content

update sample to work with firefox (no auto instanciated id)#5

Merged
addyosmani merged 1 commit intoaddyosmani:gh-pagesfrom
enguerran:firefox
Jan 6, 2015
Merged

update sample to work with firefox (no auto instanciated id)#5
addyosmani merged 1 commit intoaddyosmani:gh-pagesfrom
enguerran:firefox

Conversation

@enguerran
Copy link
Contributor

Despite the "spec", firefox cannot handle the id-to-global-variable in the demo.html.

I found some resources speaking about this spec I did not know:

What do you think?

@addyosmani
Copy link
Owner

I'm all for improving overall x-browser compat, but wasn't aware FF wasn't able to handle this properly. I'll do some testing against master and your PR to verify this is the best fix we can opt for. Thanks again (and sorry for the delay reviewing!)

@enguerran
Copy link
Contributor Author

No problem for the delay, give me some feedback when you can. We all know you can be a very busy man.

addyosmani added a commit that referenced this pull request Jan 6, 2015
update sample to work with firefox (no auto instanciated id)
@addyosmani addyosmani merged commit c50981c into addyosmani:gh-pages Jan 6, 2015
@enguerran enguerran deleted the firefox branch March 2, 2015 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants