fix: Codebase improvements and fixes#516
Merged
Merged
Conversation
…ustomReplyEditorActivity
…(deprecated API 26+)
Owner
Author
|
Need to run manual end to end tests before merging |
adeekshith
changed the title
- setHasOptionsMenu → MenuProvider with lifecycle owner - onActivityResult → registerForActivityResult (ActivityResultLauncher) - onRequestPermissionsResult → registerForActivityResult (RequestPermission) - getInstallerPackageName → getInstallSourceInfo on API 30+ - queryIntentActivities(intent, 0) → MATCH_DEFAULT_ONLY - Remove mActivity field: use requireActivity()/requireContext() instead - Remove dead onDestroy and commented-out code blocks
- Move contact permission request from Activity.requestPermissions to registerForActivityResult in ContactSelectorFragment - Remove onRequestPermissionsResult from ContactSelectorActivity - Replace deprecated onCreateOptionsMenu/onOptionsItemSelected with MenuProvider and lifecycle-aware registration
Replace bare 0 flag with PackageManager.MATCH_DEFAULT_ONLY in BrandingFragment and CustomDialog for type safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.