Raise ParserWarning not ParserError for Pandas > 1.3.5#30
Merged
Conversation
Raise a ParserWarning to avoid the ParserError `pandas.errors.ParserError: Defining usecols with out-of-bounds indices is not allowed.` when using Pandas>1.3.5. Now a warning is output for the problematic lines (which relate to comments in the JANAF data). Tested on an example txt file: https://janaf.nist.gov/tables/H-066.txt
This is related to pull request adelq#30, which requires at least Pandas 1.3.0 for the `on_bad_lines` keyword argument to be available. See https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.read_csv.html
ZGainsforth
reviewed
Mar 22, 2024
Collaborator
ZGainsforth
left a comment
ZGainsforth
left a comment
There was a problem hiding this comment.
OK. Ideally we should have a patch to fix bad lines if they follow a pattern in the JANAF data, but at least warning is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise a ParserWarning to avoid the ParserError
pandas.errors.ParserError: Defining usecols with out-of-bounds indices is not allowed.when using Pandas>1.3.5. Now a warning is output for the problematic lines (which relate to comments in the JANAF data).Tested on an example txt file: https://janaf.nist.gov/tables/H-066.txt