Develop#122
Merged
cookeac merged 12 commits intoadewg:Developfrom Jul 27, 2020
erwinspeybroeck:Develop
Merged
Conversation
Corrrected case in enumerations to address #61
…Type.json Base makes sense in the context of a Breeding Value, but when looking at ICAR specs in general, it is not clear what icarBaseIdentifierType represents. Renamed to icarBVBaseIdentifierType.
Changed base file from icarBaseIdentifierType.json to icarBVBaseIdentifierType.json
Corrected description of calculationType enumeration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added breeding values API : #89