Merged
Conversation
samparsky
force-pushed
the
rate-limit-uid
branch
4 times, most recently
from
311db44 to
a5fc577
Compare
Ivshti
requested changes
Apr 29, 2019
Contributor
Ivshti
left a comment
Ivshti
left a comment
There was a problem hiding this comment.
you've done a very good job on this, but I have a few remarks
I'm also wondering if we should match multiple rules or not
if we do, we should .map on rules and each one should return an async function (therefore a promise) and we should then await Promise.all ; basically do the rule checking in parallel
| @@ -19,7 +20,10 @@ function getMongo() { | |||
| } | |||
|
|
|||
| function getRedis() { | |||
services/sentry/lib/access.js
Outdated
| : [ | ||
| { uids: [channel.creator] }, | ||
| { uids: null, rateLimit: cfg.IP_RATE_LIMIT }, | ||
| { uids: null, rateLimit: cfg.SID_RATE_LIMIT } |
Ivshti
requested changes
May 6, 2019
test/index.js
Outdated
| const events = genEvents(2, 'working') | ||
| const allowOnlyOneEvent = await checkAccess(channel, {}, events) | ||
| t.equal(allowOnlyOneEvent.success, false, 'should not process request') | ||
| t.equal(allowOnlyOneEvent.statusCode, 429, 'shoudl ahbe err') |
test/index.js
Outdated
|
|
||
| // redis connection preventing test from closing | ||
| // hence the quit | ||
| tape.onFinish(() => db.getRedis().quit()) |
Contributor
There was a problem hiding this comment.
I think this should be a separate test file, since it's more similar to an integration test then a unit test because it requires redis and is not a pure function
Ivshti
approved these changes
May 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #132