Skip to content

Comments

Access improvements#276

Merged
Ivshti merged 5 commits intomasterfrom
access-improvements
May 24, 2020
Merged

Access improvements#276
Ivshti merged 5 commits intomasterfrom
access-improvements

Conversation

@Ivshti
Copy link
Contributor

@Ivshti Ivshti commented May 24, 2020 •
edited
Loading

  • fix typo (sid -> uid)
  • if a rateLimit is active, always restrict to one event at a time; allowing multiple effectively makes the rateLimit pointless, cause you can submit as many as you want
  • can apply rules only to certain events

Those improvements can be used for implementing AIP26/AIP29, if combined with adding further rateLimit types

@Ivshti Ivshti requested a review from samparsky May 24, 2020 10:14
@Ivshti Ivshti mentioned this pull request May 24, 2020
Merged
@Ivshti Ivshti merged commit 3d94143 into master May 24, 2020
@Ivshti Ivshti deleted the access-improvements branch June 3, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samparsky samparsky samparsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ivshti @samparsky