Skip to content

Comments

Per-channel analytics should require auth, fixes #287#288

Merged
Ivshti merged 4 commits intomasterfrom
analytics-auth
Jun 12, 2020
Merged

Per-channel analytics should require auth, fixes #287#288
Ivshti merged 4 commits intomasterfrom
analytics-auth

Conversation

@Ivshti
Copy link
Contributor

@Ivshti Ivshti commented Jun 12, 2020

The channel analytics now require that the channel creator (advertiser) authenticates.

This fixes 3 distinct issues:

  • analytics: channel-level stats should require auth #287: advertiser analytics per channel must require auth
  • calling this path with authentication actually caused earning (publisher) stats to be retrieved for this channel - leading to zero results for almost all channels except the one where the creator is both an advertiser and publisher
  • calling this path with authentication will cause it to be cached in the same cache key as every other call to it, leading to results for different callers being served

@Ivshti Ivshti requested a review from samparsky June 12, 2020 10:03
@Ivshti Ivshti merged commit ec29925 into master Jun 12, 2020
@Ivshti Ivshti deleted the analytics-auth branch June 12, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants