Skip to content

fix(etcd-backup): disallow concurrent job runs #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cfi2017 merged 4 commits into from
Dec 12, 2024
Merged

fix(etcd-backup): disallow concurrent job runs #1351

cfi2017 merged 4 commits into from
Dec 12, 2024

Conversation

@cfi2017
Copy link
Contributor

@cfi2017 cfi2017 commented Dec 12, 2024 •
edited
Loading

Description

This PR sets the concurrencyPolicy for the CronJob in kubernetes-etcd-backup to Forbid, meaning we don't try to start a new Job while the old one is still running. In case it is, the new Job is skipped.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@cfi2017 cfi2017 self-assigned this Dec 12, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2024
@cfi2017 cfi2017 marked this pull request as ready for review December 12, 2024 12:27
@cfi2017 cfi2017 requested a review from a team as a code owner December 12, 2024 12:27
hairmare
hairmare reviewed Dec 12, 2024
View reviewed changes
@cfi2017 @hairmare
chore(etcd-backup): indicate update does not contain security updates
3e84a3d 
Co-authored-by: Lucas <116588+hairmare@users.noreply.github.com>
@cfi2017 cfi2017 merged commit ba51e08 into main Dec 12, 2024
3 checks passed
@cfi2017 cfi2017 deleted the fix/etcd-backup-concurrency-policy branch December 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hairmare hairmare hairmare left review comments

@eyenx eyenx eyenx approved these changes

@inisitijitty inisitijitty Awaiting requested review from inisitijitty inisitijitty is a code owner automatically assigned from adfinis/helm-charts

@maxthier maxthier Awaiting requested review from maxthier maxthier is a code owner automatically assigned from adfinis/helm-charts

Assignees

@cfi2017 cfi2017

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cfi2017 @hairmare @eyenx